Re: [PR] [SPARK-47483][SQL] Add support for aggregation and join operations on arrays of collated strings [spark]

["dbatomic (via GitHub)" <gi...@apache.org>]

dbatomic commented on code in PR #45611:
URL: https://github.com/apache/spark/pull/45611#discussion_r1531812913


##########
sql/core/src/test/resources/sql-tests/inputs/collations.sql:
##########
@@ -77,3 +77,18 @@ select array_distinct(array('aaa' collate utf8_binary_lcase, 'AAA' collate utf8_
 select array_union(array('aaa' collate utf8_binary_lcase), array('AAA' collate utf8_binary_lcase));
 select array_intersect(array('aaa' collate utf8_binary_lcase), array('AAA' collate utf8_binary_lcase));
 select array_except(array('aaa' collate utf8_binary_lcase), array('AAA' collate utf8_binary_lcase));
+
+-- array joins & aggregates
+create table l(a array<string collate utf8_binary_lcase>) using parquet;

Review Comment:
   Seems like golden file examples are already covered by `CollationSuite`? We don't need both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org