You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/05 12:19:37 UTC

[GitHub] [flink] klion26 opened a new pull request #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

klion26 opened a new pull request #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/11022
 
 
   ## What is the purpose of the change
   
   chinese translate of #10934
   
   RocksDB compaction filter is always enabled by default after #10866 and we deprecated its disabling. The docs should not refer to its enabling/disabling. The Chinese translation still has to be adjusted separately.
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] klion26 commented on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/11022#issuecomment-582381745
 
 
   cc @azagrebin @carp84 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/11022#issuecomment-582394822
 
 
   <!--
   Meta data
   Hash:f87f0333e5e789fb59db300889bbc5c39a47ea8c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147541107 TriggerType:PUSH TriggerID:f87f0333e5e789fb59db300889bbc5c39a47ea8c
   Hash:f87f0333e5e789fb59db300889bbc5c39a47ea8c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4864 TriggerType:PUSH TriggerID:f87f0333e5e789fb59db300889bbc5c39a47ea8c
   -->
   ## CI report:
   
   * f87f0333e5e789fb59db300889bbc5c39a47ea8c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147541107) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4864) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/11022#issuecomment-582394822
 
 
   <!--
   Meta data
   Hash:f87f0333e5e789fb59db300889bbc5c39a47ea8c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147541107 TriggerType:PUSH TriggerID:f87f0333e5e789fb59db300889bbc5c39a47ea8c
   Hash:f87f0333e5e789fb59db300889bbc5c39a47ea8c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4864 TriggerType:PUSH TriggerID:f87f0333e5e789fb59db300889bbc5c39a47ea8c
   -->
   ## CI report:
   
   * f87f0333e5e789fb59db300889bbc5c39a47ea8c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147541107) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4864) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] klion26 commented on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/11022#issuecomment-584707032
 
 
   @carp84 thanks for the review and merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/11022#issuecomment-582382569
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit f87f0333e5e789fb59db300889bbc5c39a47ea8c (Wed Feb 05 12:22:29 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/11022#issuecomment-582394822
 
 
   <!--
   Meta data
   Hash:f87f0333e5e789fb59db300889bbc5c39a47ea8c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:f87f0333e5e789fb59db300889bbc5c39a47ea8c
   -->
   ## CI report:
   
   * f87f0333e5e789fb59db300889bbc5c39a47ea8c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] carp84 merged pull request #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
carp84 merged pull request #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/11022
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11022: [FLINK-15741][docs-zh][TTL] Fix TTL docs after enabling RocksDB compaction filter by default
URL: https://github.com/apache/flink/pull/11022#issuecomment-582394822
 
 
   <!--
   Meta data
   Hash:f87f0333e5e789fb59db300889bbc5c39a47ea8c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147541107 TriggerType:PUSH TriggerID:f87f0333e5e789fb59db300889bbc5c39a47ea8c
   Hash:f87f0333e5e789fb59db300889bbc5c39a47ea8c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4864 TriggerType:PUSH TriggerID:f87f0333e5e789fb59db300889bbc5c39a47ea8c
   -->
   ## CI report:
   
   * f87f0333e5e789fb59db300889bbc5c39a47ea8c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147541107) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4864) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services