You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "vbalani002 (via GitHub)" <gi...@apache.org> on 2024/07/10 15:02:41 UTC
[PR] Explicitly register Afterburner module to avoid jackson dependency conflicts [kafka]
vbalani002 opened a new pull request, #16565:
URL: https://github.com/apache/kafka/pull/16565
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17111: Explicitly Register Afterburner Module in JsonSerializer and JsonDeserializer [kafka]
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on PR #16565:
URL: https://github.com/apache/kafka/pull/16565#issuecomment-2221387172
Thanks @vbalani002 for the bug report and prompt fix! I agree with this approach, let me know when you want me to review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17111: Explicitly Register Afterburner Module in JsonSerializer and JsonDeserializer [kafka]
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on PR #16565:
URL: https://github.com/apache/kafka/pull/16565#issuecomment-2221414024
cc @divijvaidya and @mimaison who reviewed the original performance PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17111: Explicitly Register Afterburner Module in JsonSerializer and JsonDeserializer [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #16565:
URL: https://github.com/apache/kafka/pull/16565#issuecomment-2222844388
Cherry picked as well to `3.8`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17111: Explicitly Register Afterburner Module in JsonSerializer and JsonDeserializer [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat merged PR #16565:
URL: https://github.com/apache/kafka/pull/16565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17111: Explicitly Register Afterburner Module in JsonSerializer and JsonDeserializer [kafka]
Posted by "vbalani002 (via GitHub)" <gi...@apache.org>.
vbalani002 commented on PR #16565:
URL: https://github.com/apache/kafka/pull/16565#issuecomment-2222021575
Thanks for looking into this promptly, @gharris1727!
I was waiting for a green CI build before marking the PR as ready. Since there are no test failures in the pipeline, I'm opening it for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17111: Explicitly Register Afterburner Module in JsonSerializer and JsonDeserializer [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #16565:
URL: https://github.com/apache/kafka/pull/16565#issuecomment-2222582924
Test failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17111: Explicitly Register Afterburner Module in JsonSerializer and JsonDeserializer [kafka]
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on PR #16565:
URL: https://github.com/apache/kafka/pull/16565#issuecomment-2221423742
And for anyone reviewing this, it's easy to verify the change by checking the behavior of the following commands:
```
./gradlew jar
./bin/connect-plugin-path.sh list --plugin-location ~/.m2/repository/com/fasterxml/jackson
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17111: Explicitly Register Afterburner Module in JsonSerializer and JsonDeserializer [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #16565:
URL: https://github.com/apache/kafka/pull/16565#issuecomment-2222585080
@mimaison or @divijvaidya As you reviewed https://github.com/apache/kafka/pull/14992 do you want to take a look at this one as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org