You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/09 19:01:18 UTC
[GitHub] [incubator-gobblin] ZihanLi58 opened a new pull request #3033: [GOBBLIN-1185]Enable datasetCleaner to emit kafka event and add config field in Ver…
ZihanLi58 opened a new pull request #3033:
URL: https://github.com/apache/incubator-gobblin/pull/3033
…sionFinderAndPolicy
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-1185] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1185
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Add dynamic config to enable DatasetCleaner to emit kafka event
Add config field in VersionFinderAndPolicy so that CleanableDataset are aware of the config for different partition.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3033: [GOBBLIN-1185]Enable datasetCleaner to emit kafka event and add config field in Ver…
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3033:
URL: https://github.com/apache/incubator-gobblin/pull/3033#issuecomment-641647812
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=h1) Report
> Merging [#3033](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/31f2ef1478c3b5d4887cfc772f0e85057cde1c56&el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `27.27%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3033 +/- ##
============================================
+ Coverage 45.66% 45.79% +0.12%
- Complexity 9296 9329 +33
============================================
Files 1956 1956
Lines 74397 74412 +15
Branches 8247 8247
============================================
+ Hits 33977 34079 +102
+ Misses 37242 37138 -104
- Partials 3178 3195 +17
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...blin/data/management/retention/DatasetCleaner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9EYXRhc2V0Q2xlYW5lci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...tion/dataset/MultiVersionCleanableDatasetBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L011bHRpVmVyc2lvbkNsZWFuYWJsZURhdGFzZXRCYXNlLmphdmE=) | `74.07% <75.00%> (-0.61%)` | `11.00 <0.00> (ø)` | |
| [...gement/retention/dataset/CleanableDatasetBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L0NsZWFuYWJsZURhdGFzZXRCYXNlLmphdmE=) | `63.63% <100.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...etention/dataset/ConfigurableCleanableDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L0NvbmZpZ3VyYWJsZUNsZWFuYWJsZURhdGFzZXQuamF2YQ==) | `78.26% <100.00%> (+0.31%)` | `17.00 <0.00> (ø)` | |
| [.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh) | `71.87% <0.00%> (-7.82%)` | `15.00% <0.00%> (-1.00%)` | |
| [...apache/gobblin/salesforce/QueryResultIterator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvUXVlcnlSZXN1bHRJdGVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...che/gobblin/salesforce/ResultChainingIterator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvUmVzdWx0Q2hhaW5pbmdJdGVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.03% <0.00%> (+0.33%)` | `33.00% <0.00%> (ø%)` | |
| [...rg/apache/gobblin/salesforce/SalesforceSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZVNvdXJjZS5qYXZh) | `20.83% <0.00%> (+1.01%)` | `13.00% <0.00%> (+1.00%)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `60.60% <0.00%> (+1.51%)` | `15.00% <0.00%> (+1.00%)` | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=footer). Last update [31f2ef1...6225df1](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #3033: [GOBBLIN-1185]Enable datasetCleaner to emit kafka event and add config field in Ver…
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on a change in pull request #3033:
URL: https://github.com/apache/incubator-gobblin/pull/3033#discussion_r439080847
##########
File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/DatasetCleaner.java
##########
@@ -88,33 +94,43 @@
public DatasetCleaner(FileSystem fs, Properties props) throws IOException {
- State state = new State(props);
+ Properties properties = new Properties();
+ properties.putAll(props);
+ // load dynamic configuration and add them to the job properties
+ Config propsAsConfig = ConfigUtils.propertiesToConfig(props);
+ DynamicConfigGenerator dynamicConfigGenerator =
+ DynamicConfigGeneratorFactory.createDynamicConfigGenerator(propsAsConfig);
+ Config dynamicConfig = dynamicConfigGenerator.generateDynamicConfig(propsAsConfig);
+ for (Map.Entry<String, ConfigValue> entry : dynamicConfig.entrySet()) {
+ properties.put(entry.getKey(), entry.getValue().unwrapped().toString());
Review comment:
It was working well magically... But I change the code to avoid confusion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3033: [GOBBLIN-1185]Enable datasetCleaner to emit kafka event and add config field in Ver…
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #3033:
URL: https://github.com/apache/incubator-gobblin/pull/3033#discussion_r439125481
##########
File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/dataset/CleanableDatasetBase.java
##########
@@ -122,6 +122,6 @@ public CleanableDatasetBase(FileSystem fs, Properties properties, boolean simula
@Override
public List<VersionFinderAndPolicy<T>> getVersionFindersAndPolicies() {
return ImmutableList
- .<VersionFinderAndPolicy<T>> of(new VersionFinderAndPolicy<>(getRetentionPolicy(), getVersionFinder()));
+ .<VersionFinderAndPolicy<T>> of(new VersionFinderAndPolicy<>(getRetentionPolicy(), getVersionFinder(), null));
Review comment:
Shall we change it to ConfigFactory.empty() ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3033: [GOBBLIN-1185]Enable datasetCleaner to emit kafka event and add config field in Ver…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3033:
URL: https://github.com/apache/incubator-gobblin/pull/3033
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3033: [GOBBLIN-1185]Enable datasetCleaner to emit kafka event and add config field in Ver…
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3033:
URL: https://github.com/apache/incubator-gobblin/pull/3033#issuecomment-641647812
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=h1) Report
> Merging [#3033](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/31f2ef1478c3b5d4887cfc772f0e85057cde1c56&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `30.43%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3033 +/- ##
============================================
+ Coverage 45.66% 45.81% +0.14%
- Complexity 9296 9331 +35
============================================
Files 1956 1956
Lines 74397 74413 +16
Branches 8247 8247
============================================
+ Hits 33977 34089 +112
+ Misses 37242 37127 -115
- Partials 3178 3197 +19
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...blin/data/management/retention/DatasetCleaner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9EYXRhc2V0Q2xlYW5lci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...tion/dataset/MultiVersionCleanableDatasetBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L011bHRpVmVyc2lvbkNsZWFuYWJsZURhdGFzZXRCYXNlLmphdmE=) | `74.07% <75.00%> (-0.61%)` | `11.00 <0.00> (ø)` | |
| [...gement/retention/dataset/CleanableDatasetBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L0NsZWFuYWJsZURhdGFzZXRCYXNlLmphdmE=) | `66.66% <100.00%> (+3.03%)` | `3.00 <0.00> (ø)` | |
| [...etention/dataset/ConfigurableCleanableDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L0NvbmZpZ3VyYWJsZUNsZWFuYWJsZURhdGFzZXQuamF2YQ==) | `78.26% <100.00%> (+0.31%)` | `17.00 <0.00> (ø)` | |
| [.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh) | `78.12% <0.00%> (-1.57%)` | `15.00% <0.00%> (-1.00%)` | |
| [...pache/gobblin/runtime/GobblinMultiTaskAttempt.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvR29iYmxpbk11bHRpVGFza0F0dGVtcHQuamF2YQ==) | `59.83% <0.00%> (-0.41%)` | `28.00% <0.00%> (-1.00%)` | |
| [...apache/gobblin/salesforce/QueryResultIterator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvUXVlcnlSZXN1bHRJdGVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...che/gobblin/salesforce/ResultChainingIterator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvUmVzdWx0Q2hhaW5pbmdJdGVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==) | `16.21% <0.00%> (+0.81%)` | `5.00% <0.00%> (+1.00%)` | |
| [...rg/apache/gobblin/salesforce/SalesforceSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZVNvdXJjZS5qYXZh) | `20.83% <0.00%> (+1.01%)` | `13.00% <0.00%> (+1.00%)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=footer). Last update [31f2ef1...c0562e8](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3033: [GOBBLIN-1185]Enable datasetCleaner to emit kafka event and add config field in Ver…
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3033:
URL: https://github.com/apache/incubator-gobblin/pull/3033#issuecomment-641647812
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=h1) Report
> Merging [#3033](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/31f2ef1478c3b5d4887cfc772f0e85057cde1c56&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3033 +/- ##
=========================================
Coverage 45.66% 45.67%
- Complexity 9296 9300 +4
=========================================
Files 1956 1956
Lines 74397 74409 +12
Branches 8247 8248 +1
=========================================
+ Hits 33977 33987 +10
- Misses 37242 37246 +4
+ Partials 3178 3176 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...blin/data/management/retention/DatasetCleaner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9EYXRhc2V0Q2xlYW5lci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...tion/dataset/MultiVersionCleanableDatasetBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L011bHRpVmVyc2lvbkNsZWFuYWJsZURhdGFzZXRCYXNlLmphdmE=) | `74.07% <75.00%> (-0.61%)` | `11.00 <0.00> (ø)` | |
| [...gement/retention/dataset/CleanableDatasetBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L0NsZWFuYWJsZURhdGFzZXRCYXNlLmphdmE=) | `63.63% <100.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...etention/dataset/ConfigurableCleanableDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L0NvbmZpZ3VyYWJsZUNsZWFuYWJsZURhdGFzZXQuamF2YQ==) | `78.26% <100.00%> (+0.31%)` | `17.00 <0.00> (ø)` | |
| [...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=) | `47.57% <0.00%> (-1.95%)` | `12.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.56% <0.00%> (+0.66%)` | `25.00% <0.00%> (+1.00%)` | |
| [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `80.37% <0.00%> (+0.93%)` | `24.00% <0.00%> (ø%)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `60.60% <0.00%> (+1.51%)` | `15.00% <0.00%> (+1.00%)` | |
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `72.22% <0.00%> (+2.22%)` | `13.00% <0.00%> (ø%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `40.47% <0.00%> (+3.17%)` | `16.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=footer). Last update [31f2ef1...36eb11f](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #3033: [GOBBLIN-1185]Enable datasetCleaner to emit kafka event and add config field in Ver…
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on a change in pull request #3033:
URL: https://github.com/apache/incubator-gobblin/pull/3033#discussion_r439065562
##########
File path: gobblin-modules/gobblin-kafka-09/src/test/java/org/apache/gobblin/kafka/writer/Kafka09DataWriterTest.java
##########
@@ -84,7 +84,7 @@ public void testStringSerialization()
_kafkaTestHelper.provisionTopic(topic);
Properties props = new Properties();
props.setProperty(KafkaWriterConfigurationKeys.KAFKA_TOPIC, topic);
- props.setProperty(KafkaWriterConfigurationKeys.KAFKA_PRODUCER_CONFIG_PREFIX+"bootstrap.servers", "localhost:" + _kafkaTestHelper.getKafkaServerPort());
+ props.setProperty(KafkaWriterConfigurationKeys.KAFKA_PRODUCER_CONFIG_PREFIX+"bootstrap.servers", "127.0.0.1:" + _kafkaTestHelper.getKafkaServerPort());
Review comment:
First time this test hang on travis build, so I made this change to see if it helps pass the travis build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter commented on pull request #3033: [GOBBLIN-1185]Enable datasetCleaner to emit kafka event and add config field in Ver…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3033:
URL: https://github.com/apache/incubator-gobblin/pull/3033#issuecomment-641647812
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=h1) Report
> Merging [#3033](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/31f2ef1478c3b5d4887cfc772f0e85057cde1c56&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3033 +/- ##
=========================================
Coverage 45.66% 45.67%
- Complexity 9296 9300 +4
=========================================
Files 1956 1956
Lines 74397 74409 +12
Branches 8247 8248 +1
=========================================
+ Hits 33977 33987 +10
- Misses 37242 37246 +4
+ Partials 3178 3176 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...blin/data/management/retention/DatasetCleaner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9EYXRhc2V0Q2xlYW5lci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...tion/dataset/MultiVersionCleanableDatasetBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L011bHRpVmVyc2lvbkNsZWFuYWJsZURhdGFzZXRCYXNlLmphdmE=) | `74.07% <75.00%> (-0.61%)` | `11.00 <0.00> (ø)` | |
| [...gement/retention/dataset/CleanableDatasetBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L0NsZWFuYWJsZURhdGFzZXRCYXNlLmphdmE=) | `63.63% <100.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...etention/dataset/ConfigurableCleanableDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L0NvbmZpZ3VyYWJsZUNsZWFuYWJsZURhdGFzZXQuamF2YQ==) | `78.26% <100.00%> (+0.31%)` | `17.00 <0.00> (ø)` | |
| [...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=) | `47.57% <0.00%> (-1.95%)` | `12.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.56% <0.00%> (+0.66%)` | `25.00% <0.00%> (+1.00%)` | |
| [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `80.37% <0.00%> (+0.93%)` | `24.00% <0.00%> (ø%)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `60.60% <0.00%> (+1.51%)` | `15.00% <0.00%> (+1.00%)` | |
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `72.22% <0.00%> (+2.22%)` | `13.00% <0.00%> (ø%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3033/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `40.47% <0.00%> (+3.17%)` | `16.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=footer). Last update [31f2ef1...36eb11f](https://codecov.io/gh/apache/incubator-gobblin/pull/3033?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3033: [GOBBLIN-1185]Enable datasetCleaner to emit kafka event and add config field in Ver…
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #3033:
URL: https://github.com/apache/incubator-gobblin/pull/3033#discussion_r439057712
##########
File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/DatasetCleaner.java
##########
@@ -88,33 +94,43 @@
public DatasetCleaner(FileSystem fs, Properties props) throws IOException {
- State state = new State(props);
+ Properties properties = new Properties();
+ properties.putAll(props);
+ // load dynamic configuration and add them to the job properties
+ Config propsAsConfig = ConfigUtils.propertiesToConfig(props);
+ DynamicConfigGenerator dynamicConfigGenerator =
+ DynamicConfigGeneratorFactory.createDynamicConfigGenerator(propsAsConfig);
+ Config dynamicConfig = dynamicConfigGenerator.generateDynamicConfig(propsAsConfig);
+ for (Map.Entry<String, ConfigValue> entry : dynamicConfig.entrySet()) {
+ properties.put(entry.getKey(), entry.getValue().unwrapped().toString());
Review comment:
Does it work in this way ? It seems it will only get the top-level key and here it just convert the ConfigValue into a string which could itself be a hierarchical config.
##########
File path: gobblin-modules/gobblin-kafka-09/src/test/java/org/apache/gobblin/kafka/writer/Kafka09DataWriterTest.java
##########
@@ -84,7 +84,7 @@ public void testStringSerialization()
_kafkaTestHelper.provisionTopic(topic);
Properties props = new Properties();
props.setProperty(KafkaWriterConfigurationKeys.KAFKA_TOPIC, topic);
- props.setProperty(KafkaWriterConfigurationKeys.KAFKA_PRODUCER_CONFIG_PREFIX+"bootstrap.servers", "localhost:" + _kafkaTestHelper.getKafkaServerPort());
+ props.setProperty(KafkaWriterConfigurationKeys.KAFKA_PRODUCER_CONFIG_PREFIX+"bootstrap.servers", "127.0.0.1:" + _kafkaTestHelper.getKafkaServerPort());
Review comment:
why this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org