You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Philip Harvey (JIRA)" <ji...@apache.org> on 2012/08/03 13:51:03 UTC

[jira] [Created] (QPID-4187) Management ACL logging sometimes prints N/A instead of user name

Philip Harvey created QPID-4187:
-----------------------------------

             Summary: Management ACL logging sometimes prints N/A instead of user name
                 Key: QPID-4187
                 URL: https://issues.apache.org/jira/browse/QPID-4187
             Project: Qpid
          Issue Type: Bug
          Components: Java Broker
    Affects Versions: 0.16
            Reporter: Philip Harvey
            Assignee: Philip Harvey
            Priority: Minor
             Fix For: 0.19


When testing the fix for QPID-4185 we noticed that the "log actor" portion of our management ACL authorization logging sometimes prints N/A where the user name should be. 

For example, this happens if you've connected JConsole using "reconnect" rather than a new connection.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-4187) Management ACL logging sometimes prints N/A instead of user name

Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428059#comment-13428059 ] 

Philip Harvey commented on QPID-4187:
-------------------------------------

Reviewed the patch - looks good.
                
> Management ACL logging sometimes prints N/A instead of user name
> ----------------------------------------------------------------
>
>                 Key: QPID-4187
>                 URL: https://issues.apache.org/jira/browse/QPID-4187
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.16
>            Reporter: Philip Harvey
>            Assignee: Robbie Gemmell
>            Priority: Minor
>             Fix For: 0.19
>
>         Attachments: 0001-QPID-4187-Improve-operational-management-logging.patch
>
>
> When testing the fix for QPID-4186 we noticed that the "log actor" portion of our management ACL authorization logging sometimes prints N/A where the user name should be. 
> For example, this happens if you've connected JConsole using "reconnect" rather than a new connection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-4187) Management ACL logging sometimes prints N/A instead of user name

Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philip Harvey updated QPID-4187:
--------------------------------

    Description: 
When testing the fix for QPID-4186 we noticed that the "log actor" portion of our management ACL authorization logging sometimes prints N/A where the user name should be. 

For example, this happens if you've connected JConsole using "reconnect" rather than a new connection.


  was:
When testing the fix for QPID-4185 we noticed that the "log actor" portion of our management ACL authorization logging sometimes prints N/A where the user name should be. 

For example, this happens if you've connected JConsole using "reconnect" rather than a new connection.


    
> Management ACL logging sometimes prints N/A instead of user name
> ----------------------------------------------------------------
>
>                 Key: QPID-4187
>                 URL: https://issues.apache.org/jira/browse/QPID-4187
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.16
>            Reporter: Philip Harvey
>            Assignee: Philip Harvey
>            Priority: Minor
>             Fix For: 0.19
>
>
> When testing the fix for QPID-4186 we noticed that the "log actor" portion of our management ACL authorization logging sometimes prints N/A where the user name should be. 
> For example, this happens if you've connected JConsole using "reconnect" rather than a new connection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Assigned] (QPID-4187) Management ACL logging sometimes prints N/A instead of user name

Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy reassigned QPID-4187:
--------------------------------

    Assignee: Robbie Gemmell  (was: Philip Harvey)

Robbie,
Could you please commit the patch?
                
> Management ACL logging sometimes prints N/A instead of user name
> ----------------------------------------------------------------
>
>                 Key: QPID-4187
>                 URL: https://issues.apache.org/jira/browse/QPID-4187
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.16
>            Reporter: Philip Harvey
>            Assignee: Robbie Gemmell
>            Priority: Minor
>             Fix For: 0.19
>
>         Attachments: 0001-QPID-4187-Improve-operational-management-logging.patch
>
>
> When testing the fix for QPID-4186 we noticed that the "log actor" portion of our management ACL authorization logging sometimes prints N/A where the user name should be. 
> For example, this happens if you've connected JConsole using "reconnect" rather than a new connection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-4187) Management ACL logging sometimes prints N/A instead of user name

Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy updated QPID-4187:
-----------------------------

    Attachment: 0001-QPID-4187-Improve-operational-management-logging.patch

Attached a patch resolving the issue with management logging.

Phil,please review.
                
> Management ACL logging sometimes prints N/A instead of user name
> ----------------------------------------------------------------
>
>                 Key: QPID-4187
>                 URL: https://issues.apache.org/jira/browse/QPID-4187
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.16
>            Reporter: Philip Harvey
>            Assignee: Philip Harvey
>            Priority: Minor
>             Fix For: 0.19
>
>         Attachments: 0001-QPID-4187-Improve-operational-management-logging.patch
>
>
> When testing the fix for QPID-4186 we noticed that the "log actor" portion of our management ACL authorization logging sometimes prints N/A where the user name should be. 
> For example, this happens if you've connected JConsole using "reconnect" rather than a new connection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-4187) Management ACL logging sometimes prints N/A instead of user name

Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428008#comment-13428008 ] 

Philip Harvey commented on QPID-4187:
-------------------------------------

The problem is that ManagementActor caches its log message per-thread name. 

When JConsole reconnects the thread name doesn't change so ManagementActor uses its cached log string containing N/A, even though the user name is now available in the thread's Subject.
                
> Management ACL logging sometimes prints N/A instead of user name
> ----------------------------------------------------------------
>
>                 Key: QPID-4187
>                 URL: https://issues.apache.org/jira/browse/QPID-4187
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.16
>            Reporter: Philip Harvey
>            Assignee: Philip Harvey
>            Priority: Minor
>             Fix For: 0.19
>
>
> When testing the fix for QPID-4185 we noticed that the "log actor" portion of our management ACL authorization logging sometimes prints N/A where the user name should be. 
> For example, this happens if you've connected JConsole using "reconnect" rather than a new connection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Resolved] (QPID-4187) Management ACL logging sometimes prints N/A instead of user name

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell resolved QPID-4187.
----------------------------------

    Resolution: Fixed

Patch applied.
                
> Management ACL logging sometimes prints N/A instead of user name
> ----------------------------------------------------------------
>
>                 Key: QPID-4187
>                 URL: https://issues.apache.org/jira/browse/QPID-4187
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.16
>            Reporter: Philip Harvey
>            Assignee: Robbie Gemmell
>            Priority: Minor
>             Fix For: 0.19
>
>         Attachments: 0001-QPID-4187-Improve-operational-management-logging.patch
>
>
> When testing the fix for QPID-4186 we noticed that the "log actor" portion of our management ACL authorization logging sometimes prints N/A where the user name should be. 
> For example, this happens if you've connected JConsole using "reconnect" rather than a new connection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org