[jira] [Commented] (GUACAMOLE-2087) src/libguac/wol.c: inet_pton called with a destination buffer size too small

["Nick Couchman (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GUACAMOLE-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985934#comment-17985934 ] 

Nick Couchman commented on GUACAMOLE-2087:
------------------------------------------

I think this may be related to GUACAMOLE-2070, which should be fixed in the next bugfix release.

> src/libguac/wol.c: inet_pton called with a destination buffer size too small
> ----------------------------------------------------------------------------
>
>                 Key: GUACAMOLE-2087
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-2087
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole-server
>    Affects Versions: 1.6.0
>         Environment: Fedora Rawhide (equals currently to 43), all hardware architectures
>            Reporter: Robert Scheck
>            Priority: Major
>
> Building guacamole-server 1.6.0 fails at least on Fedora Rawhide like this:
> {noformat}
> ...
> /bin/sh ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../..    -Werror -Wall -pedantic -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -c -o libguac_la-wol.lo `test -f 'wol.c' || echo './'`wol.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -Werror -Wall -pedantic -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -c wol.c  -fPIC -DPIC -o .libs/libguac_la-wol.o
> make[3]: Leaving directory '/builddir/build/BUILD/guacamole-server-1.6.0-build/guacamole-server-1.6.0/src/libguac'
> In file included from /usr/include/features.h:524,
>                  from /usr/include/bits/libc-header-start.h:33,
>                  from /usr/include/stdint.h:26,
>                  from /usr/lib/gcc/x86_64-redhat-linux/15/include/stdint.h:11,
>                  from guacamole/timestamp-types.h:29,
>                  from guacamole/timestamp.h:29,
>                  from wol.c:24:
> In function 'inet_pton',
>     inlined from '__guac_wol_send_packet' at wol.c:104:18,
>     inlined from 'guac_wol_wake' at wol.c:192:22:
> /usr/include/bits/inet-fortified.h:56:10: error: call to '*__inet_pton_chk' declared with attribute warning: inet_pton called with a destination buffer size too small [-Werror=attribute-warning]
>    56 |   return __glibc_fortify (inet_pton, sz, sizeof (char),
>       |          ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[3]: *** [Makefile:1136: libguac_la-wol.lo] Error 1
> make[3]: *** Waiting for unfinished jobs....
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)