You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rave.apache.org by Erin Noe-Payne <er...@mitre.org> on 2012/08/09 19:12:19 UTC

Review Request: RAVE-756: Add support for window onhashchange event

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6496/
-----------------------------------------------------------

Review request for rave.


Description
-------

Add the jquery hash change extension to support window onhashchange event for all browsers. This will allow consistent support for client side hash navigation or linking to bootstrap tabs.


This addresses bug RAVE-756.
    https://issues.apache.org/jira/browse/RAVE-756


Diffs
-----

  trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/third_party_js.tag 1371261 

Diff: https://reviews.apache.org/r/6496/diff/


Testing
-------


Thanks,

Erin Noe-Payne

Re: Review Request: RAVE-756: Add support for window onhashchange event

Posted by Anthony Carlucci <ac...@mitre.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6496/#review10459
-----------------------------------------------------------

Ship it!


LGTM!

- Anthony Carlucci


On Aug. 9, 2012, 5:12 p.m., Erin Noe-Payne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6496/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 5:12 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Add the jquery hash change extension to support window onhashchange event for all browsers. This will allow consistent support for client side hash navigation or linking to bootstrap tabs.
> 
> 
> This addresses bug RAVE-756.
>     https://issues.apache.org/jira/browse/RAVE-756
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/third_party_js.tag 1371261 
> 
> Diff: https://reviews.apache.org/r/6496/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erin Noe-Payne
> 
>