You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2014/03/23 01:08:17 UTC
Empty folders
Hi,
I noticed that we have a number of empty folders, 30 actually:
applications/accounting/webapp/accounting/images
applications/accounting/webapp/accounting/lookup
applications/content/src/org/ofbiz/content/test
applications/marketing/script/org/ofbiz/sfa/opportunity
applications/marketing/webapp/sfa/account
applications/marketing/webapp/sfa/party
applications/order/webapp/ordermgr/includes
applications/order/webapp/ordermgr/WEB-INF/actions/report
applications/product/webapp/catalog/includes
applications/workeffort/src/org/ofbiz/workeffort/project
framework/base/cert/demoCA/certs
framework/base/cert/demoCA/crl
framework/webapp/src/org/ofbiz/webapp/test
framework/webtools/webapp/webtools/component
framework/webtools/webapp/webtools/includes
specialpurpose/birt/lib/scriptlib
specialpurpose/birt/src/org/ofbiz/birt/report/context
specialpurpose/birt/webapp/birt/WEB-INF/attachments
specialpurpose/cmssite/template/docbook/epub/bin
specialpurpose/cmssite/template/docbook/epub/bin/lib
specialpurpose/cmssite/template/docbook/epub/bin/xslt
specialpurpose/cmssite/template/docbook/tools/bin
specialpurpose/example/webapp/exampleext/WEB-INF
specialpurpose/oagis/webapp/oagis/WEB-INF/actions
specialpurpose/oagis/webapp/oagis/WEB-INF/actions/message
specialpurpose/scrum/dtd
specialpurpose/scrum/lib
specialpurpose/scrum/patches
specialpurpose/scrum/webapp/demotest/actions
specialpurpose/scrum/webapp/demotest/WEB-INF/actions
I just had a look at the 4 1st ones and they are residues of commits where a last inside files was removed but not the folder, this without any valid
reasons.*
*Though for the 1st one
applications/accounting/webapp/accounting/images
this could be discussed. Because Hans removed/replaced an Ajax functionnality rather than fixing it. There are maybe valid reasons for that, but this
would need to be verified.
I ask about them, because, as you might know, Git does not handle empty folders. So this can be a pain where you have to put place holders files for
Git to keep the empty folders.
On the other hand you could say that it's not a probem because these folders are useless. So why care about then in Git?
Because there are enough (30) empty folders to let ask yourself about which ones to keep (put a place holder in) and which ones to drop (let Git
forget them).
Also a person asking this question would rather ask, why to keep them, if they are useless!
So I will continue to check that, to remove all those that are definitively useless.
Jacques
Re: Empty folders
Posted by Jacques Le Roux <ja...@les7arts.com>.
Adding a README is a good point Pierre. Thanks for the idea (already used elsewhere but yes we should extend). I will do that where needed others dirs
will be ruthlessly removed.
Jacques
Le 24/03/2014 09:07, Pierre Smits a écrit :
> I would say that there is no need to keep these given that they don't hold
> content. If empty folders do serve a purpose (e.g. the hot-deploy folder
> and lib folders in components), it should hold a readme doc explaining the
> purpose.
>
> Regards,
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
Re: Empty folders
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Deepak,
I have used your description to create a README there
Jacques
Le 24/03/2014 10:18, Deepak Dixit a écrit :
> This is used for content upload purpose. And if we deployed ofbiz using git then content upload process does now working and its return error.
Re: Empty folders
Posted by Deepak Dixit <de...@hotwaxmedia.com>.
HI Jacques,
We have also an empty folder tmp in runtime. This is used for content upload purpose. And if we deployed ofbiz using git then content upload process does now working and its return error.
Thanks & Regards
--
Deepak Dixit
On Mar 24, 2014, at 1:37 PM, Pierre Smits wrote:
> I would say that there is no need to keep these given that they don't hold
> content. If empty folders do serve a purpose (e.g. the hot-deploy folder
> and lib folders in components), it should hold a readme doc explaining the
> purpose.
>
> Regards,
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
Re: Empty folders
Posted by Pierre Smits <pi...@gmail.com>.
I would say that there is no need to keep these given that they don't hold
content. If empty folders do serve a purpose (e.g. the hot-deploy folder
and lib folders in components), it should hold a readme doc explaining the
purpose.
Regards,
Pierre Smits
*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com
Re: Empty folders
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Carsten,
I'm reluctant to let Git forget them all. In case something new happens there. So, for now, I prefer to put place holders in them. I will check each
in detail...
Thanks
Jacques
Le 23/03/2014 20:46, c.schinzer@gmail.com a écrit :
> Thanks for the initiative, Jacques.
>
> I do 'forget' them in my own repos for OFBiz delivery since I moved to github. I am fully for a removal from SVN, too. Naming conventions on folders in components are rigid enough to put them back in place once required again.
>
> I like this feature in git as it keeps a cleaner and legacy-free non-whatif structure of repositories.
>
> My two cents.
>
> Carsten
>
> Gesendet von unterwegs mit BlackBerry® Webmail.
>
> -----Original Message-----
> From: Jacques Le Roux <ja...@les7arts.com>
> Date: Sun, 23 Mar 2014 01:08:17
> To: dev@ofbiz.apache.org<de...@ofbiz.apache.org>
> Reply-To: dev@ofbiz.apache.org
> Subject: Empty folders
>
> Hi,
>
> I noticed that we have a number of empty folders, 30 actually:
>
> applications/accounting/webapp/accounting/images
> applications/accounting/webapp/accounting/lookup
> applications/content/src/org/ofbiz/content/test
> applications/marketing/script/org/ofbiz/sfa/opportunity
> applications/marketing/webapp/sfa/account
> applications/marketing/webapp/sfa/party
> applications/order/webapp/ordermgr/includes
> applications/order/webapp/ordermgr/WEB-INF/actions/report
> applications/product/webapp/catalog/includes
> applications/workeffort/src/org/ofbiz/workeffort/project
> framework/base/cert/demoCA/certs
> framework/base/cert/demoCA/crl
> framework/webapp/src/org/ofbiz/webapp/test
> framework/webtools/webapp/webtools/component
> framework/webtools/webapp/webtools/includes
> specialpurpose/birt/lib/scriptlib
> specialpurpose/birt/src/org/ofbiz/birt/report/context
> specialpurpose/birt/webapp/birt/WEB-INF/attachments
> specialpurpose/cmssite/template/docbook/epub/bin
> specialpurpose/cmssite/template/docbook/epub/bin/lib
> specialpurpose/cmssite/template/docbook/epub/bin/xslt
> specialpurpose/cmssite/template/docbook/tools/bin
> specialpurpose/example/webapp/exampleext/WEB-INF
> specialpurpose/oagis/webapp/oagis/WEB-INF/actions
> specialpurpose/oagis/webapp/oagis/WEB-INF/actions/message
> specialpurpose/scrum/dtd
> specialpurpose/scrum/lib
> specialpurpose/scrum/patches
> specialpurpose/scrum/webapp/demotest/actions
> specialpurpose/scrum/webapp/demotest/WEB-INF/actions
>
>
> I just had a look at the 4 1st ones and they are residues of commits where a last inside files was removed but not the folder, this without any valid
> reasons.*
> *Though for the 1st one
> applications/accounting/webapp/accounting/images
> this could be discussed. Because Hans removed/replaced an Ajax functionnality rather than fixing it. There are maybe valid reasons for that, but this
> would need to be verified.
>
> I ask about them, because, as you might know, Git does not handle empty folders. So this can be a pain where you have to put place holders files for
> Git to keep the empty folders.
> On the other hand you could say that it's not a probem because these folders are useless. So why care about then in Git?
> Because there are enough (30) empty folders to let ask yourself about which ones to keep (put a place holder in) and which ones to drop (let Git
> forget them).
> Also a person asking this question would rather ask, why to keep them, if they are useless!
>
> So I will continue to check that, to remove all those that are definitively useless.
>
> Jacques
>
>
>
>
Re: Empty folders
Posted by c....@gmail.com.
Thanks for the initiative, Jacques.
I do 'forget' them in my own repos for OFBiz delivery since I moved to github. I am fully for a removal from SVN, too. Naming conventions on folders in components are rigid enough to put them back in place once required again.
I like this feature in git as it keeps a cleaner and legacy-free non-whatif structure of repositories.
My two cents.
Carsten
Gesendet von unterwegs mit BlackBerry® Webmail.
-----Original Message-----
From: Jacques Le Roux <ja...@les7arts.com>
Date: Sun, 23 Mar 2014 01:08:17
To: dev@ofbiz.apache.org<de...@ofbiz.apache.org>
Reply-To: dev@ofbiz.apache.org
Subject: Empty folders
Hi,
I noticed that we have a number of empty folders, 30 actually:
applications/accounting/webapp/accounting/images
applications/accounting/webapp/accounting/lookup
applications/content/src/org/ofbiz/content/test
applications/marketing/script/org/ofbiz/sfa/opportunity
applications/marketing/webapp/sfa/account
applications/marketing/webapp/sfa/party
applications/order/webapp/ordermgr/includes
applications/order/webapp/ordermgr/WEB-INF/actions/report
applications/product/webapp/catalog/includes
applications/workeffort/src/org/ofbiz/workeffort/project
framework/base/cert/demoCA/certs
framework/base/cert/demoCA/crl
framework/webapp/src/org/ofbiz/webapp/test
framework/webtools/webapp/webtools/component
framework/webtools/webapp/webtools/includes
specialpurpose/birt/lib/scriptlib
specialpurpose/birt/src/org/ofbiz/birt/report/context
specialpurpose/birt/webapp/birt/WEB-INF/attachments
specialpurpose/cmssite/template/docbook/epub/bin
specialpurpose/cmssite/template/docbook/epub/bin/lib
specialpurpose/cmssite/template/docbook/epub/bin/xslt
specialpurpose/cmssite/template/docbook/tools/bin
specialpurpose/example/webapp/exampleext/WEB-INF
specialpurpose/oagis/webapp/oagis/WEB-INF/actions
specialpurpose/oagis/webapp/oagis/WEB-INF/actions/message
specialpurpose/scrum/dtd
specialpurpose/scrum/lib
specialpurpose/scrum/patches
specialpurpose/scrum/webapp/demotest/actions
specialpurpose/scrum/webapp/demotest/WEB-INF/actions
I just had a look at the 4 1st ones and they are residues of commits where a last inside files was removed but not the folder, this without any valid
reasons.*
*Though for the 1st one
applications/accounting/webapp/accounting/images
this could be discussed. Because Hans removed/replaced an Ajax functionnality rather than fixing it. There are maybe valid reasons for that, but this
would need to be verified.
I ask about them, because, as you might know, Git does not handle empty folders. So this can be a pain where you have to put place holders files for
Git to keep the empty folders.
On the other hand you could say that it's not a probem because these folders are useless. So why care about then in Git?
Because there are enough (30) empty folders to let ask yourself about which ones to keep (put a place holder in) and which ones to drop (let Git
forget them).
Also a person asking this question would rather ask, why to keep them, if they are useless!
So I will continue to check that, to remove all those that are definitively useless.
Jacques
Re: Empty folders
Posted by Jacques Le Roux <ja...@les7arts.com>.
Done at svn.apache.org/viewvc?view=revision&revision=r1580865
I was not sure these empty folders were useless so please check
specialpurpose/oagis/webapp/oagis/WEB-INF/actions
specialpurpose/oagis/webapp/oagis/WEB-INF/actions/message
Were not concerned (in list below due to an error in our Git repo)
specialpurpose/cmssite/template/docbook/epub/bin
specialpurpose/cmssite/template/docbook/epub/bin/lib
specialpurpose/cmssite/template/docbook/epub/bin/xslt
specialpurpose/cmssite/template/docbook/tools/bin
Jacques
Le 23/03/2014 01:08, Jacques Le Roux a écrit :
> Hi,
>
> I noticed that we have a number of empty folders, 30 actually:
>
> applications/accounting/webapp/accounting/images
> applications/accounting/webapp/accounting/lookup
> applications/content/src/org/ofbiz/content/test
> applications/marketing/script/org/ofbiz/sfa/opportunity
> applications/marketing/webapp/sfa/account
> applications/marketing/webapp/sfa/party
> applications/order/webapp/ordermgr/includes
> applications/order/webapp/ordermgr/WEB-INF/actions/report
> applications/product/webapp/catalog/includes
> applications/workeffort/src/org/ofbiz/workeffort/project
> framework/base/cert/demoCA/certs
> framework/base/cert/demoCA/crl
> framework/webapp/src/org/ofbiz/webapp/test
> framework/webtools/webapp/webtools/component
> framework/webtools/webapp/webtools/includes
> specialpurpose/birt/lib/scriptlib
> specialpurpose/birt/src/org/ofbiz/birt/report/context
> specialpurpose/birt/webapp/birt/WEB-INF/attachments
> specialpurpose/cmssite/template/docbook/epub/bin
> specialpurpose/cmssite/template/docbook/epub/bin/lib
> specialpurpose/cmssite/template/docbook/epub/bin/xslt
> specialpurpose/cmssite/template/docbook/tools/bin
> specialpurpose/example/webapp/exampleext/WEB-INF
> specialpurpose/oagis/webapp/oagis/WEB-INF/actions
> specialpurpose/oagis/webapp/oagis/WEB-INF/actions/message
> specialpurpose/scrum/dtd
> specialpurpose/scrum/lib
> specialpurpose/scrum/patches
> specialpurpose/scrum/webapp/demotest/actions
> specialpurpose/scrum/webapp/demotest/WEB-INF/actions
>
>
> I just had a look at the 4 1st ones and they are residues of commits where a last inside files was removed but not the folder, this without any
> valid reasons.*
> *Though for the 1st one
> applications/accounting/webapp/accounting/images
> this could be discussed. Because Hans removed/replaced an Ajax functionnality rather than fixing it. There are maybe valid reasons for that, but
> this would need to be verified.
>
> I ask about them, because, as you might know, Git does not handle empty folders. So this can be a pain where you have to put place holders files for
> Git to keep the empty folders.
> On the other hand you could say that it's not a probem because these folders are useless. So why care about then in Git?
> Because there are enough (30) empty folders to let ask yourself about which ones to keep (put a place holder in) and which ones to drop (let Git
> forget them).
> Also a person asking this question would rather ask, why to keep them, if they are useless!
>
> So I will continue to check that, to remove all those that are definitively useless.
>
> Jacques
>
>