You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/12/12 19:21:44 UTC

Review Request 54671: Changed the timing of entering mount namespace for DEBUG container.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54671/
-----------------------------------------------------------

Review request for mesos and Kevin Klues.


Repository: mesos


Description
-------

Now, we entered the mount namespace of the target container for the
DEBUG container at the same place as we do pivot root for normal
containers. This behavior is more consistent.


Diffs
-----

  src/slave/containerizer/mesos/launch.cpp f90fce200d52a13b1db0727139b9a530666783a1 

Diff: https://reviews.apache.org/r/54671/diff/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 54671: Changed the timing of entering mount namespace for DEBUG container.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54671/#review158896
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Dec. 12, 2016, 7:21 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54671/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 7:21 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now, we entered the mount namespace of the target container for the
> DEBUG container at the same place as we do pivot root for normal
> containers. This behavior is more consistent.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launch.cpp f90fce200d52a13b1db0727139b9a530666783a1 
> 
> Diff: https://reviews.apache.org/r/54671/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>