You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/15 17:14:47 UTC

[GitHub] [incubator-superset] codecov-io commented on pull request #11289: keep placeholder on multiselect

codecov-io commented on pull request #11289:
URL: https://github.com/apache/incubator-superset/pull/11289#issuecomment-709468885


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11289?src=pr&el=h1) Report
   > Merging [#11289](https://codecov.io/gh/apache/incubator-superset/pull/11289?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9aef9c5764ebf995c9ab8955684b408397037e1e?el=desc) will **increase** coverage by `1.24%`.
   > The diff coverage is `57.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11289/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11289?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11289      +/-   ##
   ==========================================
   + Coverage   61.50%   62.74%   +1.24%     
   ==========================================
     Files         834      441     -393     
     Lines       39557    14732   -24825     
     Branches     3610     3614       +4     
   ==========================================
   - Hits        24329     9244   -15085     
   + Misses      15047     5306    -9741     
   - Partials      181      182       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.74% <57.14%> (+0.02%)` | :arrow_up: |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11289?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11289/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.19% <ø> (ø)` | |
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11289/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `83.92% <33.33%> (-0.92%)` | :arrow_down: |
   | [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11289/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `59.67% <63.63%> (+4.12%)` | :arrow_up: |
   | [superset/db\_engine\_specs/redshift.py](https://codecov.io/gh/apache/incubator-superset/pull/11289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3JlZHNoaWZ0LnB5) | | |
   | [...tions/versions/e9df189e5c7e\_update\_base\_metrics.py](https://codecov.io/gh/apache/incubator-superset/pull/11289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lOWRmMTg5ZTVjN2VfdXBkYXRlX2Jhc2VfbWV0cmljcy5weQ==) | | |
   | [...40e8ea\_change\_table\_schema\_description\_to\_long\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84OTExNWE0MGU4ZWFfY2hhbmdlX3RhYmxlX3NjaGVtYV9kZXNjcmlwdGlvbl90b19sb25nXy5weQ==) | | |
   | [...80aa3f04bc82\_add\_parent\_ids\_in\_dashboard\_layout.py](https://codecov.io/gh/apache/incubator-superset/pull/11289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MGFhM2YwNGJjODJfYWRkX3BhcmVudF9pZHNfaW5fZGFzaGJvYXJkX2xheW91dC5weQ==) | | |
   | [...ions/versions/a2d606a761d9\_adding\_favstar\_model.py](https://codecov.io/gh/apache/incubator-superset/pull/11289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hMmQ2MDZhNzYxZDlfYWRkaW5nX2ZhdnN0YXJfbW9kZWwucHk=) | | |
   | [superset/css\_templates/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | | |
   | [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | | |
   | ... and [388 more](https://codecov.io/gh/apache/incubator-superset/pull/11289/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11289?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11289?src=pr&el=footer). Last update [9aef9c5...a2f1f75](https://codecov.io/gh/apache/incubator-superset/pull/11289?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org