You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "kezhenxu94 (GitHub)" <gi...@apache.org> on 2019/02/05 04:48:56 UTC

[GitHub] [incubator-dubbo-ops] kezhenxu94 opened pull request #293: add rat plugin to avoid source file without license. #290

Related issue #290 and #272 (sorry for that I just add checkstyle plugin and forget to add rat plugin too in #273 )

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/293 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] kezhenxu94 closed pull request #293: add rat plugin to avoid source file without license. #290

Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
[ pull request closed by kezhenxu94 ]

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/293 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on issue #293: add rat plugin to avoid source file without license. #290

Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
close it since it's added at [commit](https://github.com/apache/incubator-dubbo-ops/commit/82ddf71944e0a6674df1ce9d0e1a134b21a60da7#diff-600376dffeb79835ede4a0b285078036R199)

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/293 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #293: add rat plugin to avoid source file without license. #290

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=h1) Report
> Merging [#293](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/4262b471e034af5e2325227024ab4cc68059ff50?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             develop    #293   +/-   ##
=========================================
  Coverage       23.2%   23.2%           
  Complexity       345     345           
=========================================
  Files             91      91           
  Lines           3650    3650           
  Branches         570     570           
=========================================
  Hits             847     847           
  Misses          2712    2712           
  Partials          91      91
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/dubbo/admin/service/impl/GenericServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL0dlbmVyaWNTZXJ2aWNlSW1wbC5qYXZh) | `52.63% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| [...g/apache/dubbo/admin/model/dto/ServiceTestDTO.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZHRvL1NlcnZpY2VUZXN0RFRPLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/controller/ServiceTestController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlVGVzdENvbnRyb2xsZXIuamF2YQ==) | `16.66% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=footer). Last update [4262b47...5b75e0e](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/293 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #293: add rat plugin to avoid source file without license. #290

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=h1) Report
> Merging [#293](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/4262b471e034af5e2325227024ab4cc68059ff50?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             develop    #293   +/-   ##
=========================================
  Coverage       23.2%   23.2%           
  Complexity       345     345           
=========================================
  Files             91      91           
  Lines           3650    3650           
  Branches         570     570           
=========================================
  Hits             847     847           
  Misses          2712    2712           
  Partials          91      91
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/dubbo/admin/service/impl/GenericServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9pbXBsL0dlbmVyaWNTZXJ2aWNlSW1wbC5qYXZh) | `52.63% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| [...g/apache/dubbo/admin/model/dto/ServiceTestDTO.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZHRvL1NlcnZpY2VUZXN0RFRPLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/controller/ServiceTestController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlVGVzdENvbnRyb2xsZXIuamF2YQ==) | `16.66% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=footer). Last update [4262b47...5b75e0e](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/293 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org