[jira] [Commented] (ORC-698) Add safety check for negative dictionary lengths

["Hao Fu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560785#comment-17560785 ] 

Hao Fu commented on ORC-698:
----------------------------

This seems can be resolved.

 

 

```

haofu@C02CJ3WFMD6T src % ./orc-scan ../../../examples/corrupt/negative_dict_entry_lengths.orc 

Caught exception in ../../../examples/corrupt/negative_dict_entry_lengths.orc: Negative dictionary entry length

```

> Add safety check for negative dictionary lengths
> ------------------------------------------------
>
>                 Key: ORC-698
>                 URL: https://issues.apache.org/jira/browse/ORC-698
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Major
>
> In testing ORC-697, we don't fail when reading corrupt/negative_dict_entry_lengths.orc because we don't try to look at the strings. We should add a check when reading the dictionaries that the lengths are between 0 and the end of the buffer.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)