[GitHub] [phoenix] stoty commented on a change in pull request #1143: PHOENIX-6359 : New module to support HBase 2.4.1+ releases

[GitBox <gi...@apache.org>]

stoty commented on a change in pull request #1143:
URL: https://github.com/apache/phoenix/pull/1143#discussion_r576578073



##########
File path: phoenix-hbase-compat-2.4.1/pom.xml
##########
@@ -0,0 +1,108 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+<project
+  xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation=
+    "http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.apache.phoenix</groupId>
+    <artifactId>phoenix</artifactId>
+    <version>5.2.0-SNAPSHOT</version>
+  </parent>
+
+  <artifactId>phoenix-hbase-compat-2.4.1</artifactId>
+  <name>Phoenix Hbase 2.4.1 compatibility</name>
+  <description>Compatibility module for HBase 2.4.1+</description>

Review comment:
       Should remove the + from 2.4.0 module.

##########
File path: pom.xml
##########
@@ -86,12 +87,13 @@
     <hbase.suffix>hbase-${hbase.profile}</hbase.suffix>
 
     <!-- This is used by the release script only -->
-    <hbase.profile.list>2.1 2.2 2.3 2.4</hbase.profile.list>
+    <hbase.profile.list>2.1 2.2 2.3 2.4 2.4.1</hbase.profile.list>

Review comment:
       Now this is wehere our current system kind of falls apart.
   
   So far we have avoided supporting multiple patch leveles for the same HBase minor version.
   
   Adding support for more than one patch level presents a challange.
   
   One way to solve it - as you have done here - is to make each one into a full-blown profile.
   In many ways this is the best solution, but we run the risk of exploding the number of profiles, going from four profiles and binaries to 5,6,or 10.
   
   In this case, we should rename the profile names, as 2.4 working with 2.4.0 instead of the latest version is counter-intuitive.
   
   The other soultion, that I originally had in mind was to map the profiles to the latest supported patch level, and only build official binaries for those.
   
   In this case we need to document this fact, and provide instructions on how to build for older patch lelvels.
   
   this would be something like 
   `mvn clean install -Dhbase.profile=2.4 -Dhbase.compat.version=2.4.0 -Dhbase.version=2.4.0`
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org