You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/19 13:18:27 UTC

[GitHub] [spark] gengliangwang opened a new pull request #24145: [SPARK-27201][WebUI] Show full job description on click

gengliangwang opened a new pull request #24145: [SPARK-27201][WebUI] Show full job description on click
URL: https://github.com/apache/spark/pull/24145
 
 
   ## What changes were proposed in this pull request?
   
   Previously, in https://github.com/apache/spark/pull/6646 there was an improvement to show full job description after double clicks.
   I think this is a bit hard to be noticed by some users. I suggest changing the event to one click.
   Also, after the full description is shown, another click should be able to hide the overflow text again.
   
   Before click:
   ![屏幕快照 2019-03-19 下午9 17 27](https://user-images.githubusercontent.com/1097932/54608784-79bfca80-4a8c-11e9-912b-30799be0d6cb.png)
   
   After click:
   ![屏幕快照 2019-03-19 下午9 17 35](https://user-images.githubusercontent.com/1097932/54608790-7b898e00-4a8c-11e9-9251-86061158db68.png)
   
   Click again:
   ![屏幕快照 2019-03-19 下午9 17 27](https://user-images.githubusercontent.com/1097932/54608784-79bfca80-4a8c-11e9-912b-30799be0d6cb.png)
   
   ## How was this patch tested?
   
   Manually check.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org