You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Kaben123 (via GitHub)" <gi...@apache.org> on 2026/01/23 03:29:22 UTC
[PR] driver/ramlog: Implement the rate limiting function for ramlog driver. [nuttx]
Kaben123 opened a new pull request, #18127:
URL: https://github.com/apache/nuttx/pull/18127
Limit the maximum number of log entries allowed within the specified time interval in seconds.
*Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
## Summary
*Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.*
## Impact
*Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.*
## Testing
*This section should provide a detailed description of what you did
to verify your changes work and do not break existing code.*
*Please provide information about your host machine, the board(s) you
tested your changes on, and how you tested. Logs should be included.*
*For example, when changing something in the core OS functions, you
may want to run the OSTest application to verify that there are no
regressions. Changes to ADC code may warrant running the `adc`
example. Adding a new uORB driver may require that you run
`uorb_listener` to verify correct operation.*
*Pure documentation changes can just be tested with `make html`
(see docs) and verification of the correct format in your
browser.*
**_PRs without testing information will not be accepted. We will
request test logs._**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] driver/syslog: Implement the rate limiting function for ramlog driver. [nuttx]
Posted by "linguini1 (via GitHub)" <gi...@apache.org>.
linguini1 commented on PR #18127:
URL: https://github.com/apache/nuttx/pull/18127#issuecomment-3800256161
@xiaoxiang781216 even if the review comment can be resolved, please stop dismissing my review comments. We voted on this in the mailing list and we've discussed it numerous times: it's up to the reviewer to dismiss their own change requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] driver/syslog: Implement the rate limiting function for ramlog driver. [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #18127:
URL: https://github.com/apache/nuttx/pull/18127#issuecomment-3799708321
> > @Kaben123 thank you for adding a new feature to syslog. All new features need to be properly documented. Please update https://nuttx.apache.org/docs/latest/components/drivers/special/syslog.html#syslog
> > Where and how these new IOCTLs will be called? Please provide some tool to control syslog?
> > In the Linux kernel we have /proc/sys/kernel/printk_ratelimit to control kernel printk rate limit. For the journald we have /etc/systemd/journald.conf:
> > ```
> > RateLimitIntervalSec=30s
> > RateLimitBurst=1000
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > We need to have something similar or at least a Kconfig to setup the default parameters
>
> There is no interface like /proc/sys/kernel/printk_ratelimit in Linux. Patches will be submitted later that implement something like printk_ratelimit.
>
Maybe it was removed, but that is something that existed on Linux:
https://www.reddit.com/r/linuxquestions/comments/1iq73ef/remove_kernel_log_printk_rate_limits/
https://docs.kernel.org/admin-guide/sysctl/kernel.html#printk-ratelimit
> The rl_ratelimit.interval defaults to 0, in which case ramlog does not make any effort to limit flow. Each ramlog instance supports individual rate limiting configuration.
>
> The documentation for the new RAMLOG rate limiting feature and IOCTLs has been added to the syslog driver documentation, including usage and a sample NSH command implementation (see "RAMLOG Rate Limiting" section).
>
> Please help review. Thanks! @acassis
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] driver/syslog: Implement the rate limiting function for ramlog driver. [nuttx]
Posted by "Kaben123 (via GitHub)" <gi...@apache.org>.
Kaben123 commented on PR #18127:
URL: https://github.com/apache/nuttx/pull/18127#issuecomment-3799537860
> @Kaben123 thank you for adding a new feature to syslog. All new features need to be properly documented. Please update https://nuttx.apache.org/docs/latest/components/drivers/special/syslog.html#syslog
>
> Where and how these new IOCTLs will be called? Please provide some tool to control syslog?
>
> In the Linux kernel we have /proc/sys/kernel/printk_ratelimit to control kernel printk rate limit. For the journald we have /etc/systemd/journald.conf:
>
> ```
> RateLimitIntervalSec=30s
> RateLimitBurst=1000
> ```
>
> We need to have something similar or at least a Kconfig to setup the default parameters
There is no interface like /proc/sys/kernel/printk_ratelimit in Linux. Patches will be submitted later that implement something like printk_ratelimit.
The rl_ratelimit.interval defaults to 0, in which case ramlog does not make any effort to limit flow. Each ramlog instance supports individual rate limiting configuration.
The documentation for the new RAMLOG rate limiting feature and IOCTLs has been added to the syslog driver documentation, including usage and a sample NSH command implementation (see "RAMLOG Rate Limiting" section).
Please help review. Thanks! @acassis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] driver/syslog: Implement the rate limiting function for ramlog driver. [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #18127:
URL: https://github.com/apache/nuttx/pull/18127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org