You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/07/03 10:23:01 UTC
[GitHub] [drill] KazydubB opened a new pull request #2093: DRILL-7764: Cleanup warning messages in GuavaPatcher class
KazydubB opened a new pull request #2093:
URL: https://github.com/apache/drill/pull/2093
# [DRILL-7764](https://issues.apache.org/jira/browse/DRILL-7764): Cleanup warning messages in GuavaPatcher class
## Description
Removed unnecessary logging of stack trace (on `WARN` level) when patching Guava fails.
## Documentation
N/A
## Testing
Ran all existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] KazydubB commented on a change in pull request #2093: DRILL-7764: Cleanup warning messages in GuavaPatcher class
Posted by GitBox <gi...@apache.org>.
KazydubB commented on a change in pull request #2093:
URL: https://github.com/apache/drill/pull/2093#discussion_r449575594
##########
File path: common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java
##########
@@ -73,7 +73,8 @@ private static void patchStopwatch() {
logger.info("Google's Stopwatch patched for old HBase Guava version.");
} catch (Exception e) {
- logger.warn("Unable to patch Guava classes.", e);
+ logger.warn("Unable to patch Guava classes: {}", e.getMessage());
Review comment:
Thanks, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] sanel commented on a change in pull request #2093: DRILL-7764: Cleanup warning messages in GuavaPatcher class
Posted by GitBox <gi...@apache.org>.
sanel commented on a change in pull request #2093:
URL: https://github.com/apache/drill/pull/2093#discussion_r449513573
##########
File path: common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java
##########
@@ -73,7 +73,8 @@ private static void patchStopwatch() {
logger.info("Google's Stopwatch patched for old HBase Guava version.");
} catch (Exception e) {
- logger.warn("Unable to patch Guava classes.", e);
+ logger.warn("Unable to patch Guava classes: {}", e.getMessage());
Review comment:
These calls can be wrapped in a small static function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] KazydubB merged pull request #2093: DRILL-7764: Cleanup warning messages in GuavaPatcher class
Posted by GitBox <gi...@apache.org>.
KazydubB merged pull request #2093:
URL: https://github.com/apache/drill/pull/2093
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org