You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2017/05/10 11:58:13 UTC

[GitHub] kafka pull request #3010: KAFKA-5184, KAFKA-5173; Call `closeSasl` from `Mul...

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/3010

    KAFKA-5184, KAFKA-5173; Call `closeSasl` from `MultipleListenersWithSameSecurityProtocolBaseTest`

    Also:
    1. Refactor the code to make it easier to reason about
    2. Add an assert that may possibly help us narrow down how KAFKA-5184
    can happen (it seems impossible).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-5184-kafka-5173-sasl-issues

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3010.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3010
    
----
commit 2dc3b79bd57362e4d4df5db10661034c451f9e74
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-05-10T11:43:55Z

    Fix exception message in `getNode` and `getBrokerEndPoint`

commit 9b157abfeda0d24d2585f915e4038406290096b0
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-05-10T11:51:39Z

    Refactor `SaslSetup` to make it easier to reason about

commit 80ae9b2d1a1c9f8d3ea52f3466b5df5eb7208faa
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-05-10T11:52:20Z

    Call `closeSasl` in tearDown of `MultipleListenersWithSameSecurityProtocolBaseTest`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3010: KAFKA-5184, KAFKA-5173; Various improvements to SA...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3010


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---