You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by ec...@apache.org on 2020/11/06 16:23:58 UTC

[geode] 01/01: GEODE-8681: peer-to-peer message loss due to sending connection closing with TLS enabled (#5699) (#5714)

This is an automated email from the ASF dual-hosted git repository.

echobravo pushed a commit to branch support/1.12
in repository https://gitbox.apache.org/repos/asf/geode.git

commit f80d41ae4cefdc22f5b4fe2830fd38e34b44765b
Merge: 9b2aea9 3660bb5
Author: Ernie Burghardt <eb...@pivotal.io>
AuthorDate: Fri Nov 6 08:23:19 2020 -0800

    GEODE-8681: peer-to-peer message loss due to sending connection closing with TLS enabled (#5699) (#5714)
    
    A socket-read could pick up more than one message and a single unwrap()
    could decrypt multiple messages.
    Normally the engine isn't closed and it reports normal
    status from an unwrap() operation, and Connection.processInputBuffer
    picks up each message, one by one, from the buffer and dispatches them.
    But if the SSLEngine is closed we were ignoring any already-decrypted
    data sitting in the unwrapped buffer and instead we were throwing an SSLException.
    
    (cherry picked from commit 7da8f9b516ac1e2525a1dfc922af7bfb8995f2c6)
    
    Co-authored-by: Bruce Schuchardt <bs...@pivotal.io>

 .../geode/ClusterCommunicationsDUnitTest.java      | 85 ++++++++++++++++++++--
 .../apache/geode/internal/net/NioSslEngine.java    | 12 ++-
 .../geode/internal/net/NioSslEngineTest.java       | 29 +++++++-
 3 files changed, 113 insertions(+), 13 deletions(-)