[jira] [Comment Edited] (OFBIZ-5905) Change createPartyRelationshipAndRole to use ensurePartyRole

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242673#comment-14242673 ] 

Jacques Le Roux edited comment on OFBIZ-5905 at 12/11/14 3:20 PM:
------------------------------------------------------------------

HI Gareth, there is currently a [discussion|http://markmail.org/message/z7h4bjzazh67kte4] about createPartyRole vs ensurePartyRole in the dev ML after OFBIZ-5853. In my opininon we should replace the createPartyRole implementation by the ensurePartyRole one


was (Author: jacques.le.roux):
HI Gareth there is currently a [discussion|http://markmail.org/message/z7h4bjzazh67kte4] about createPartyRole vs ensurePartyRole in the dev ML after OFBIZ-5853. In my opininon we should replace the createPartyRole implemantation by the ensurePartyRole

> Change createPartyRelationshipAndRole to use ensurePartyRole
> ------------------------------------------------------------
>
>                 Key: OFBIZ-5905
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5905
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Trunk
>            Reporter: Gareth Carter
>            Priority: Minor
>
> createPartyRelationshipAndRole in party/servicedef/services.xml invokes createPartyRole and then createPartyRelationship. It would be better if createPartyRole was changed to ensurePartyRole so that createPartyRelationshipAndRole can be called without the risk of a duplicate key error in PartyRole



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)