[GitHub] [incubator-dubbo] carryxyh opened issue #2882: Replace the map in dubbo with longObjectMap

["carryxyh (GitHub)" <gi...@apache.org>]

We can use longObjectMap to replace Map<Long, Object> in dubbo to improve performance.

We need to do the following:
1. Organize the map that can be replaced
2. Perform replacement work

我们可以使用longObjectMap来替换dubbo中的Map<Long,Object>来提升性能。

我们需要做下面的事情：
1. 整理可以替换的Map
2. 进行替换工作

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2882 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] htynkn commented on issue #2882: Replace the map in dubbo with longObjectMap

["htynkn (GitHub)" <gi...@apache.org>]

this work make sense, but do we have a official way to measure performance improvement? we don't have benchmark running in CI or other stable platform.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2882 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #2882: Replace the map in dubbo with longObjectMap

["carryxyh (GitHub)" <gi...@apache.org>]

@bpaull1981 
Hi, seems like @water-coder has claimed this job.

@water-coder I'd like to help u to finish this.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2882 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] bpaull1981 commented on issue #2882: Replace the map in dubbo with longObjectMap

["bpaull1981 (GitHub)" <gi...@apache.org>]

Can you help me with the details of the process


On Wed, Dec 12, 2018, 4:15 AM water-coder <notifications@github.com wrote:

> for this issue
> I want to do this job of using longObjectMap replacing LongObjectMap.
> I am willing to take this task and I will start doing it.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-dubbo/issues/2882#issuecomment-446533994>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/Ari7Px1gTgSlUqUHmKbJtqkXgHy7YTSUks5u4NcmgaJpZM4ZAIEY>
> .
>


[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2882 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] water-coder commented on issue #2882: Replace the map in dubbo with longObjectMap

["water-coder (GitHub)" <gi...@apache.org>]

for this issue
I want to do this job of using longObjectMap replacing LongObjectMap.
I am willing to take this task and I will start doing it.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2882 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] water-coder commented on issue #2882: Replace the map in dubbo with longObjectMap

["water-coder (GitHub)" <gi...@apache.org>]

@carryxyh 
OK,thx. I will try my best to do this.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2882 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #2882: Replace the map in dubbo with longObjectMap

["carryxyh (GitHub)" <gi...@apache.org>]

@lexburner 
I think we should have a benchmark about the sync long object map and concurrent map.
Personally think the concurrent map is better, but we should have a benchmark about this two cases.
The person who claimed this task will go to the benchmark, we have already passed the mail.

Another thing, maybe my description is problematic, we are going to replace longobjectmap and other maps such as intobjectmap. Not just longobjectmap.

And the longobjectmap and intobjectmap has many impls (not just in netty). Could u give some ideas about this?

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2882 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #2882: Replace the map in dubbo with longObjectMap

["carryxyh (GitHub)" <gi...@apache.org>]

good question. At the moment we really lack the internal benchmark. I think you can add a benchmark to the module. The performance of the new submission benchmark cannot be significantly lower than the previous benchmark results. What do u think?

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2882 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org