[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #3670: [Improvement][remote] set connect time out

[GitBox <gi...@apache.org>]

CalvinKirs commented on a change in pull request #3670:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3670#discussion_r483953681



##########
File path: dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/config/NettyClientConfig.java
##########
@@ -39,15 +40,20 @@
     private boolean soKeepalive = true;
 
     /**
-     *  send buffer size
+     * send buffer size
      */
     private int sendBufferSize = 65535;
 
     /**
-     *  receive buffer size
+     * receive buffer size
      */
     private int receiveBufferSize = 65535;
 
+    /**
+     * connect timeout millis
+     */
+    private int connectTimeoutMillis = 3;

Review comment:
       Thank you very much for your suggestion, this is indeed my mistake, 3 millis is so small




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org