You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by "张铎 (Duo Zhang)" <pa...@gmail.com> on 2021/04/20 02:57:46 UTC

[VOTE] Merge branch HBASE-22120 back to master

HBASE-22120 aims to use OpenTelemetry to replace HTrace and bring tracing
back to HBase.

The discusson thread:

https://lists.apache.org/thread.html/r31a147c184e379681987b536685db4260af16bbcb0f047ec966b22d5%40%3Cdev.hbase.apache.org%3E

The PR

https://github.com/apache/hbase/pull/2901

Please vote:
[+1] Agree
[0] Neutral
[-1] Disagree (please include actionable feedback)

Thanks.

Re: [VOTE] Merge branch HBASE-22120 back to master

Posted by Andrew Purtell <an...@gmail.com>.

+1


> On Apr 19, 2021, at 7:58 PM, 张铎 <pa...@gmail.com> wrote:
> 
> HBASE-22120 aims to use OpenTelemetry to replace HTrace and bring tracing
> back to HBase.
> 
> The discusson thread:
> 
> https://lists.apache.org/thread.html/r31a147c184e379681987b536685db4260af16bbcb0f047ec966b22d5%40%3Cdev.hbase.apache.org%3E
> 
> The PR
> 
> https://github.com/apache/hbase/pull/2901
> 
> Please vote:
> [+1] Agree
> [0] Neutral
> [-1] Disagree (please include actionable feedback)
> 
> Thanks.

Re: [VOTE] Merge branch HBASE-22120 back to master

Posted by Stack <st...@duboce.net>.

+1 from me.
S

On Mon, Apr 19, 2021 at 7:58 PM 张铎(Duo Zhang) <pa...@gmail.com> wrote:

> HBASE-22120 aims to use OpenTelemetry to replace HTrace and bring tracing
> back to HBase.
>
> The discusson thread:
>
>
> https://lists.apache.org/thread.html/r31a147c184e379681987b536685db4260af16bbcb0f047ec966b22d5%40%3Cdev.hbase.apache.org%3E
>
> The PR
>
> https://github.com/apache/hbase/pull/2901
>
> Please vote:
> [+1] Agree
> [0] Neutral
> [-1] Disagree (please include actionable feedback)
>
> Thanks.
>

Re: [VOTE] Merge branch HBASE-22120 back to master

Posted by Guanghao Zhang <zg...@gmail.com>.

+1

Anoop John <an...@gmail.com> 于2021年4月25日周日 下午3:13写道：

> +1
>
> Anoop
>
>
> On Sat, Apr 24, 2021 at 9:31 PM 张铎(Duo Zhang) <pa...@gmail.com>
> wrote:
>
> > So we have 5 +1s now, it is enough to merge this feature branch back to
> > master.
> >
> > Will merge soon.
> >
> > Thanks all for voting!
> >
> > 张铎(Duo Zhang) <pa...@gmail.com> 于2021年4月24日周六 下午11:54写道：
> >
> > > This is for merging a feature branch, not a release, so I do not think
> > > here we have binding or non-binding votes? Or at least, the vote from
> > > committers should also be considered as 'binding'.
> > >
> > > See this section in our ref guide.
> > >
> > > https://hbase.apache.org/book.html#_decisions
> > >
> > > When the feature is ready for commit, 3 +1s from committers will get
> your
> > >> feature merged.
> > >
> > >
> > > Anyway, I really think we should have a page like what the flink
> > community
> > > have
> > >
> > >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=120731026
> > >
> > > Bharath Vissapragada <bh...@apache.org> 于2021年4月22日周四 上午12:53写道：
> > >
> > >> +1, skimmed through the patch. Thanks for putting this together.
> > >>
> > >> On Tue, Apr 20, 2021 at 10:06 PM Tak-Lon (Stephen) Wu <
> > taklwu@apache.org>
> > >> wrote:
> > >>
> > >> > +1 (non-binding)
> > >> >
> > >> > This is a great integration, thanks Duo.
> > >> >
> > >> > -Stephen
> > >> >
> > >> > On Tue, Apr 20, 2021 at 9:53 PM Pankaj Kumar <
> pankajkumar@apache.org>
> > >> > wrote:
> > >> > >
> > >> > > +1(non-binding)
> > >> > >
> > >> > > Regards,
> > >> > > Pankaj
> > >> > >
> > >> > > On Tue, Apr 20, 2021, 8:28 AM 张铎(Duo Zhang) <
> palomino219@gmail.com>
> > >> > wrote:
> > >> > >
> > >> > > > HBASE-22120 aims to use OpenTelemetry to replace HTrace and
> bring
> > >> > tracing
> > >> > > > back to HBase.
> > >> > > >
> > >> > > > The discusson thread:
> > >> > > >
> > >> > > >
> > >> > > >
> > >> >
> > >>
> >
> https://lists.apache.org/thread.html/r31a147c184e379681987b536685db4260af16bbcb0f047ec966b22d5%40%3Cdev.hbase.apache.org%3E
> > >> > > >
> > >> > > > The PR
> > >> > > >
> > >> > > > https://github.com/apache/hbase/pull/2901
> > >> > > >
> > >> > > > Please vote:
> > >> > > > [+1] Agree
> > >> > > > [0] Neutral
> > >> > > > [-1] Disagree (please include actionable feedback)
> > >> > > >
> > >> > > > Thanks.
> > >> > > >
> > >> >
> > >>
> > >
> >
>

Re: [VOTE] Merge branch HBASE-22120 back to master

Posted by Anoop John <an...@gmail.com>.

+1

Anoop


On Sat, Apr 24, 2021 at 9:31 PM 张铎(Duo Zhang) <pa...@gmail.com> wrote:

> So we have 5 +1s now, it is enough to merge this feature branch back to
> master.
>
> Will merge soon.
>
> Thanks all for voting!
>
> 张铎(Duo Zhang) <pa...@gmail.com> 于2021年4月24日周六 下午11:54写道：
>
> > This is for merging a feature branch, not a release, so I do not think
> > here we have binding or non-binding votes? Or at least, the vote from
> > committers should also be considered as 'binding'.
> >
> > See this section in our ref guide.
> >
> > https://hbase.apache.org/book.html#_decisions
> >
> > When the feature is ready for commit, 3 +1s from committers will get your
> >> feature merged.
> >
> >
> > Anyway, I really think we should have a page like what the flink
> community
> > have
> >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=120731026
> >
> > Bharath Vissapragada <bh...@apache.org> 于2021年4月22日周四 上午12:53写道：
> >
> >> +1, skimmed through the patch. Thanks for putting this together.
> >>
> >> On Tue, Apr 20, 2021 at 10:06 PM Tak-Lon (Stephen) Wu <
> taklwu@apache.org>
> >> wrote:
> >>
> >> > +1 (non-binding)
> >> >
> >> > This is a great integration, thanks Duo.
> >> >
> >> > -Stephen
> >> >
> >> > On Tue, Apr 20, 2021 at 9:53 PM Pankaj Kumar <pa...@apache.org>
> >> > wrote:
> >> > >
> >> > > +1(non-binding)
> >> > >
> >> > > Regards,
> >> > > Pankaj
> >> > >
> >> > > On Tue, Apr 20, 2021, 8:28 AM 张铎(Duo Zhang) <pa...@gmail.com>
> >> > wrote:
> >> > >
> >> > > > HBASE-22120 aims to use OpenTelemetry to replace HTrace and bring
> >> > tracing
> >> > > > back to HBase.
> >> > > >
> >> > > > The discusson thread:
> >> > > >
> >> > > >
> >> > > >
> >> >
> >>
> https://lists.apache.org/thread.html/r31a147c184e379681987b536685db4260af16bbcb0f047ec966b22d5%40%3Cdev.hbase.apache.org%3E
> >> > > >
> >> > > > The PR
> >> > > >
> >> > > > https://github.com/apache/hbase/pull/2901
> >> > > >
> >> > > > Please vote:
> >> > > > [+1] Agree
> >> > > > [0] Neutral
> >> > > > [-1] Disagree (please include actionable feedback)
> >> > > >
> >> > > > Thanks.
> >> > > >
> >> >
> >>
> >
>

Re: [VOTE] Merge branch HBASE-22120 back to master

Posted by "张铎 (Duo Zhang)" <pa...@gmail.com>.

So we have 5 +1s now, it is enough to merge this feature branch back to
master.

Will merge soon.

Thanks all for voting!

张铎(Duo Zhang) <pa...@gmail.com> 于2021年4月24日周六 下午11:54写道：

> This is for merging a feature branch, not a release, so I do not think
> here we have binding or non-binding votes? Or at least, the vote from
> committers should also be considered as 'binding'.
>
> See this section in our ref guide.
>
> https://hbase.apache.org/book.html#_decisions
>
> When the feature is ready for commit, 3 +1s from committers will get your
>> feature merged.
>
>
> Anyway, I really think we should have a page like what the flink community
> have
>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=120731026
>
> Bharath Vissapragada <bh...@apache.org> 于2021年4月22日周四 上午12:53写道：
>
>> +1, skimmed through the patch. Thanks for putting this together.
>>
>> On Tue, Apr 20, 2021 at 10:06 PM Tak-Lon (Stephen) Wu <ta...@apache.org>
>> wrote:
>>
>> > +1 (non-binding)
>> >
>> > This is a great integration, thanks Duo.
>> >
>> > -Stephen
>> >
>> > On Tue, Apr 20, 2021 at 9:53 PM Pankaj Kumar <pa...@apache.org>
>> > wrote:
>> > >
>> > > +1(non-binding)
>> > >
>> > > Regards,
>> > > Pankaj
>> > >
>> > > On Tue, Apr 20, 2021, 8:28 AM 张铎(Duo Zhang) <pa...@gmail.com>
>> > wrote:
>> > >
>> > > > HBASE-22120 aims to use OpenTelemetry to replace HTrace and bring
>> > tracing
>> > > > back to HBase.
>> > > >
>> > > > The discusson thread:
>> > > >
>> > > >
>> > > >
>> >
>> https://lists.apache.org/thread.html/r31a147c184e379681987b536685db4260af16bbcb0f047ec966b22d5%40%3Cdev.hbase.apache.org%3E
>> > > >
>> > > > The PR
>> > > >
>> > > > https://github.com/apache/hbase/pull/2901
>> > > >
>> > > > Please vote:
>> > > > [+1] Agree
>> > > > [0] Neutral
>> > > > [-1] Disagree (please include actionable feedback)
>> > > >
>> > > > Thanks.
>> > > >
>> >
>>
>

Re: [VOTE] Merge branch HBASE-22120 back to master

Posted by "张铎 (Duo Zhang)" <pa...@gmail.com>.

This is for merging a feature branch, not a release, so I do not think here
we have binding or non-binding votes? Or at least, the vote from committers
should also be considered as 'binding'.

See this section in our ref guide.

https://hbase.apache.org/book.html#_decisions

When the feature is ready for commit, 3 +1s from committers will get your
> feature merged.


Anyway, I really think we should have a page like what the flink community
have

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=120731026

Bharath Vissapragada <bh...@apache.org> 于2021年4月22日周四 上午12:53写道：

> +1, skimmed through the patch. Thanks for putting this together.
>
> On Tue, Apr 20, 2021 at 10:06 PM Tak-Lon (Stephen) Wu <ta...@apache.org>
> wrote:
>
> > +1 (non-binding)
> >
> > This is a great integration, thanks Duo.
> >
> > -Stephen
> >
> > On Tue, Apr 20, 2021 at 9:53 PM Pankaj Kumar <pa...@apache.org>
> > wrote:
> > >
> > > +1(non-binding)
> > >
> > > Regards,
> > > Pankaj
> > >
> > > On Tue, Apr 20, 2021, 8:28 AM 张铎(Duo Zhang) <pa...@gmail.com>
> > wrote:
> > >
> > > > HBASE-22120 aims to use OpenTelemetry to replace HTrace and bring
> > tracing
> > > > back to HBase.
> > > >
> > > > The discusson thread:
> > > >
> > > >
> > > >
> >
> https://lists.apache.org/thread.html/r31a147c184e379681987b536685db4260af16bbcb0f047ec966b22d5%40%3Cdev.hbase.apache.org%3E
> > > >
> > > > The PR
> > > >
> > > > https://github.com/apache/hbase/pull/2901
> > > >
> > > > Please vote:
> > > > [+1] Agree
> > > > [0] Neutral
> > > > [-1] Disagree (please include actionable feedback)
> > > >
> > > > Thanks.
> > > >
> >
>

Re: [VOTE] Merge branch HBASE-22120 back to master

Posted by Bharath Vissapragada <bh...@apache.org>.

+1, skimmed through the patch. Thanks for putting this together.

On Tue, Apr 20, 2021 at 10:06 PM Tak-Lon (Stephen) Wu <ta...@apache.org>
wrote:

> +1 (non-binding)
>
> This is a great integration, thanks Duo.
>
> -Stephen
>
> On Tue, Apr 20, 2021 at 9:53 PM Pankaj Kumar <pa...@apache.org>
> wrote:
> >
> > +1(non-binding)
> >
> > Regards,
> > Pankaj
> >
> > On Tue, Apr 20, 2021, 8:28 AM 张铎(Duo Zhang) <pa...@gmail.com>
> wrote:
> >
> > > HBASE-22120 aims to use OpenTelemetry to replace HTrace and bring
> tracing
> > > back to HBase.
> > >
> > > The discusson thread:
> > >
> > >
> > >
> https://lists.apache.org/thread.html/r31a147c184e379681987b536685db4260af16bbcb0f047ec966b22d5%40%3Cdev.hbase.apache.org%3E
> > >
> > > The PR
> > >
> > > https://github.com/apache/hbase/pull/2901
> > >
> > > Please vote:
> > > [+1] Agree
> > > [0] Neutral
> > > [-1] Disagree (please include actionable feedback)
> > >
> > > Thanks.
> > >
>

Re: [VOTE] Merge branch HBASE-22120 back to master

Posted by "Tak-Lon (Stephen) Wu" <ta...@apache.org>.

+1 (non-binding)

This is a great integration, thanks Duo.

-Stephen

On Tue, Apr 20, 2021 at 9:53 PM Pankaj Kumar <pa...@apache.org> wrote:
>
> +1(non-binding)
>
> Regards,
> Pankaj
>
> On Tue, Apr 20, 2021, 8:28 AM 张铎(Duo Zhang) <pa...@gmail.com> wrote:
>
> > HBASE-22120 aims to use OpenTelemetry to replace HTrace and bring tracing
> > back to HBase.
> >
> > The discusson thread:
> >
> >
> > https://lists.apache.org/thread.html/r31a147c184e379681987b536685db4260af16bbcb0f047ec966b22d5%40%3Cdev.hbase.apache.org%3E
> >
> > The PR
> >
> > https://github.com/apache/hbase/pull/2901
> >
> > Please vote:
> > [+1] Agree
> > [0] Neutral
> > [-1] Disagree (please include actionable feedback)
> >
> > Thanks.
> >

Re: [VOTE] Merge branch HBASE-22120 back to master

Posted by Pankaj Kumar <pa...@apache.org>.

+1(non-binding)

Regards,
Pankaj

On Tue, Apr 20, 2021, 8:28 AM 张铎(Duo Zhang) <pa...@gmail.com> wrote:

> HBASE-22120 aims to use OpenTelemetry to replace HTrace and bring tracing
> back to HBase.
>
> The discusson thread:
>
>
> https://lists.apache.org/thread.html/r31a147c184e379681987b536685db4260af16bbcb0f047ec966b22d5%40%3Cdev.hbase.apache.org%3E
>
> The PR
>
> https://github.com/apache/hbase/pull/2901
>
> Please vote:
> [+1] Agree
> [0] Neutral
> [-1] Disagree (please include actionable feedback)
>
> Thanks.
>