You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "amaliujia (via GitHub)" <gi...@apache.org> on 2024/05/28 20:39:47 UTC
[PR] [SPARK-48444] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
amaliujia opened a new pull request, #46778:
URL: https://github.com/apache/spark/pull/46778
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Use withSQLConf in tests when it is appropriate.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Enforce good practice for setting config in test cases.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
NO
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing UT
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #46778:
URL: https://github.com/apache/spark/pull/46778#discussion_r1618204541
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -1108,35 +1110,31 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
}
test("dynamic partition value test") {
- try {
- sql("set hive.exec.dynamic.partition.mode=nonstrict")
- // date
- sql("drop table if exists dynparttest1")
- sql("create table dynparttest1 (value int) partitioned by (pdate date)")
- sql(
- """
- |insert into table dynparttest1 partition(pdate)
- | select count(*), cast('2015-05-21' as date) as pdate from src
- """.stripMargin)
- checkAnswer(
- sql("select * from dynparttest1"),
- Seq(Row(500, java.sql.Date.valueOf("2015-05-21"))))
+ withTable("dynparttest1", "dynparttest2") {
+ withSQLConf("hive.exec.dynamic.partition.mode" -> "strict") {
+ sql("set hive.exec.dynamic.partition.mode=nonstrict")
Review Comment:
So previous code does something like
1. set the mode
2. the recover it by the finally so other test cases are not impacted.
The new code also set the mode, and recover it by `withSQLConf`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #46778:
URL: https://github.com/apache/spark/pull/46778#issuecomment-2136068638
@cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #46778:
URL: https://github.com/apache/spark/pull/46778#issuecomment-2137938899
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #46778:
URL: https://github.com/apache/spark/pull/46778#discussion_r1618141218
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -1108,35 +1110,31 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
}
test("dynamic partition value test") {
- try {
- sql("set hive.exec.dynamic.partition.mode=nonstrict")
- // date
- sql("drop table if exists dynparttest1")
- sql("create table dynparttest1 (value int) partitioned by (pdate date)")
- sql(
- """
- |insert into table dynparttest1 partition(pdate)
- | select count(*), cast('2015-05-21' as date) as pdate from src
- """.stripMargin)
- checkAnswer(
- sql("select * from dynparttest1"),
- Seq(Row(500, java.sql.Date.valueOf("2015-05-21"))))
+ withTable("dynparttest1", "dynparttest2") {
+ withSQLConf("hive.exec.dynamic.partition.mode" -> "strict") {
+ sql("set hive.exec.dynamic.partition.mode=nonstrict")
Review Comment:
This behave different now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #46778:
URL: https://github.com/apache/spark/pull/46778#discussion_r1618217722
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -1108,35 +1110,31 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
}
test("dynamic partition value test") {
- try {
- sql("set hive.exec.dynamic.partition.mode=nonstrict")
- // date
- sql("drop table if exists dynparttest1")
- sql("create table dynparttest1 (value int) partitioned by (pdate date)")
- sql(
- """
- |insert into table dynparttest1 partition(pdate)
- | select count(*), cast('2015-05-21' as date) as pdate from src
- """.stripMargin)
- checkAnswer(
- sql("select * from dynparttest1"),
- Seq(Row(500, java.sql.Date.valueOf("2015-05-21"))))
+ withTable("dynparttest1", "dynparttest2") {
+ withSQLConf("hive.exec.dynamic.partition.mode" -> "strict") {
+ sql("set hive.exec.dynamic.partition.mode=nonstrict")
Review Comment:
https://github.com/apache/spark/pull/46778#discussion_r1618216246 move the following questions there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #46778:
URL: https://github.com/apache/spark/pull/46778#discussion_r1618230146
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -1108,35 +1110,30 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
}
test("dynamic partition value test") {
- try {
- sql("set hive.exec.dynamic.partition.mode=nonstrict")
- // date
- sql("drop table if exists dynparttest1")
- sql("create table dynparttest1 (value int) partitioned by (pdate date)")
- sql(
- """
- |insert into table dynparttest1 partition(pdate)
- | select count(*), cast('2015-05-21' as date) as pdate from src
- """.stripMargin)
- checkAnswer(
- sql("select * from dynparttest1"),
- Seq(Row(500, java.sql.Date.valueOf("2015-05-21"))))
+ withTable("dynparttest1", "dynparttest2") {
+ withSQLConf("hive.exec.dynamic.partition.mode" -> "strict") {
Review Comment:
oops this is right. yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #46778:
URL: https://github.com/apache/spark/pull/46778#discussion_r1618148340
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -1108,35 +1110,31 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
}
test("dynamic partition value test") {
- try {
- sql("set hive.exec.dynamic.partition.mode=nonstrict")
- // date
- sql("drop table if exists dynparttest1")
- sql("create table dynparttest1 (value int) partitioned by (pdate date)")
- sql(
- """
- |insert into table dynparttest1 partition(pdate)
- | select count(*), cast('2015-05-21' as date) as pdate from src
- """.stripMargin)
- checkAnswer(
- sql("select * from dynparttest1"),
- Seq(Row(500, java.sql.Date.valueOf("2015-05-21"))))
+ withTable("dynparttest1", "dynparttest2") {
+ withSQLConf("hive.exec.dynamic.partition.mode" -> "strict") {
+ sql("set hive.exec.dynamic.partition.mode=nonstrict")
Review Comment:
It still seems wrong to me. You should test with an inner wrapper using `withSQLConf + nonstrict` and restore the `strict` mode with an outer wrapper `try-finally`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #46778: [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite
URL: https://github.com/apache/spark/pull/46778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #46778:
URL: https://github.com/apache/spark/pull/46778#discussion_r1618143133
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -1108,35 +1110,31 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
}
test("dynamic partition value test") {
- try {
- sql("set hive.exec.dynamic.partition.mode=nonstrict")
- // date
- sql("drop table if exists dynparttest1")
- sql("create table dynparttest1 (value int) partitioned by (pdate date)")
- sql(
- """
- |insert into table dynparttest1 partition(pdate)
- | select count(*), cast('2015-05-21' as date) as pdate from src
- """.stripMargin)
- checkAnswer(
- sql("select * from dynparttest1"),
- Seq(Row(500, java.sql.Date.valueOf("2015-05-21"))))
+ withTable("dynparttest1", "dynparttest2") {
+ withSQLConf("hive.exec.dynamic.partition.mode" -> "strict") {
+ sql("set hive.exec.dynamic.partition.mode=nonstrict")
Review Comment:
nice catch. updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #46778:
URL: https://github.com/apache/spark/pull/46778#discussion_r1618185941
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -1108,35 +1110,31 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
}
test("dynamic partition value test") {
- try {
- sql("set hive.exec.dynamic.partition.mode=nonstrict")
- // date
- sql("drop table if exists dynparttest1")
- sql("create table dynparttest1 (value int) partitioned by (pdate date)")
- sql(
- """
- |insert into table dynparttest1 partition(pdate)
- | select count(*), cast('2015-05-21' as date) as pdate from src
- """.stripMargin)
- checkAnswer(
- sql("select * from dynparttest1"),
- Seq(Row(500, java.sql.Date.valueOf("2015-05-21"))))
+ withTable("dynparttest1", "dynparttest2") {
+ withSQLConf("hive.exec.dynamic.partition.mode" -> "strict") {
+ sql("set hive.exec.dynamic.partition.mode=nonstrict")
Review Comment:
That is the purpose of using `withSQLConfig`. So each test case should set the configs it needs and restores only to default values.
A test case should not pollute other test cases nor care about starting values of confs of other test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #46778:
URL: https://github.com/apache/spark/pull/46778#discussion_r1618141218
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -1108,35 +1110,31 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
}
test("dynamic partition value test") {
- try {
- sql("set hive.exec.dynamic.partition.mode=nonstrict")
- // date
- sql("drop table if exists dynparttest1")
- sql("create table dynparttest1 (value int) partitioned by (pdate date)")
- sql(
- """
- |insert into table dynparttest1 partition(pdate)
- | select count(*), cast('2015-05-21' as date) as pdate from src
- """.stripMargin)
- checkAnswer(
- sql("select * from dynparttest1"),
- Seq(Row(500, java.sql.Date.valueOf("2015-05-21"))))
+ withTable("dynparttest1", "dynparttest2") {
+ withSQLConf("hive.exec.dynamic.partition.mode" -> "strict") {
+ sql("set hive.exec.dynamic.partition.mode=nonstrict")
Review Comment:
This behaves differently now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #46778:
URL: https://github.com/apache/spark/pull/46778#discussion_r1618216246
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -1108,35 +1110,30 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
}
test("dynamic partition value test") {
- try {
- sql("set hive.exec.dynamic.partition.mode=nonstrict")
- // date
- sql("drop table if exists dynparttest1")
- sql("create table dynparttest1 (value int) partitioned by (pdate date)")
- sql(
- """
- |insert into table dynparttest1 partition(pdate)
- | select count(*), cast('2015-05-21' as date) as pdate from src
- """.stripMargin)
- checkAnswer(
- sql("select * from dynparttest1"),
- Seq(Row(500, java.sql.Date.valueOf("2015-05-21"))))
+ withTable("dynparttest1", "dynparttest2") {
+ withSQLConf("hive.exec.dynamic.partition.mode" -> "strict") {
Review Comment:
shouldn't it be nonstrict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48444][SQL][TESTS] Use withSQLConf in tests: Refactor SQLQuerySuite [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #46778:
URL: https://github.com/apache/spark/pull/46778#discussion_r1618198634
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -1108,35 +1110,31 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
}
test("dynamic partition value test") {
- try {
- sql("set hive.exec.dynamic.partition.mode=nonstrict")
- // date
- sql("drop table if exists dynparttest1")
- sql("create table dynparttest1 (value int) partitioned by (pdate date)")
- sql(
- """
- |insert into table dynparttest1 partition(pdate)
- | select count(*), cast('2015-05-21' as date) as pdate from src
- """.stripMargin)
- checkAnswer(
- sql("select * from dynparttest1"),
- Seq(Row(500, java.sql.Date.valueOf("2015-05-21"))))
+ withTable("dynparttest1", "dynparttest2") {
+ withSQLConf("hive.exec.dynamic.partition.mode" -> "strict") {
+ sql("set hive.exec.dynamic.partition.mode=nonstrict")
Review Comment:
So replacing `nonstrict` with `strict` is an intentional change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org