You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/25 11:10:58 UTC
[GitHub] [doris] starocean999 opened a new pull request, #13655: [fix](joinoutput all value from no-null side of outer join
starocean999 opened a new pull request, #13655:
URL: https://github.com/apache/doris/pull/13655
# Proposed changes
Issue Number: close #xxx
## Problem summary
1. move _convert_block_to_null right after _do_evaluate function
2. output all values from no-null side of outer join
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #13655: [fix](join)output all value from no-null side of outer join
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #13655:
URL: https://github.com/apache/doris/pull/13655#issuecomment-1291329126
Please add some test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13655: [fix](join)output all value from no-null side of outer join
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13655:
URL: https://github.com/apache/doris/pull/13655#issuecomment-1292082859
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.52 seconds
load time: 569 seconds
storage size: 17154644789 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221026215017_clickbench_pr_34401.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13655: [fix](join)output all value from no-null side of outer join
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13655:
URL: https://github.com/apache/doris/pull/13655#issuecomment-1291853435
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 39.14 seconds
load time: 593 seconds
storage size: 17154821058 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221026105546_clickbench_pr_34298.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13655: [fix](join)output all value from no-null side of outer join
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13655:
URL: https://github.com/apache/doris/pull/13655#issuecomment-1292896451
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13655: [fix](join)output all value from no-null side of outer join
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13655:
URL: https://github.com/apache/doris/pull/13655#issuecomment-1292896486
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13655: [fix](join)output all value from no-null side of outer join
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13655:
URL: https://github.com/apache/doris/pull/13655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org