You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Angryrou <gi...@git.apache.org> on 2017/05/03 18:06:16 UTC
[GitHub] spark pull request #17843: [Streaming] groupByKey should also disable map si...
GitHub user Angryrou opened a pull request:
https://github.com/apache/spark/pull/17843
[Streaming] groupByKey should also disable map side combine in streaming.
## What changes were proposed in this pull request?
set the argument `mapSideCombine = false` like what rxin did 4 years ago in [[SPARK-772]](https://github.com/mesos/spark/pull/651/commits/6738178d0daf1bbe7441db7c0c773a29bb2ec388) to disable map side combine when a Dstream instance uses the `groupByKey` transformation.
## How was this patch tested?
passed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Angryrou/spark lch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17843.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17843
----
commit 4ea96f5a6349a34e54b2e815584b8ef900f91d60
Author: Kawhiii <ch...@163.com>
Date: 2017-05-03T17:23:57Z
groupByKey should also disable map side combine in streaming.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17843: [Streaming] groupByKey should also disable map side comb...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17843
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17843: [Streaming] groupByKey should also disable map side comb...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17843
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17843: [Streaming] groupByKey should also disable map side comb...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17843
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17843: [Streaming] groupByKey should also disable map si...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17843
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17843: [Streaming] groupByKey should also disable map side comb...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17843
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17843: [Streaming] groupByKey should also disable map side comb...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17843
There's no real explanation here of why; I think this should be closed
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org