You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2016/10/12 19:00:54 UTC

[GitHub] cordova-lib pull request #503: CB-11994 - appveyor tests on cordova-lib are ...

GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-lib/pull/503

    CB-11994 - appveyor tests on cordova-lib are not testing on all node versions

    ### Platforms affected
    
    Self
    
    ### What does this PR do?
    
    appveyor.yml wasn't testing on all the specified versions of node, it was only testing on 4.x (LTS)
    
    ### What testing has been done on this change?
    
    About to find out on AppVeyor :)
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-lib CB-11994

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #503
    
----
commit e3bd311eed943dde2bb039e4fe80784c61777fa7
Author: Shazron Abdullah <sh...@apache.org>
Date:   2016-10-12T18:58:34Z

    CB-11994 - appveyor tests on cordova-lib are not testing on all node versions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib pull request #503: CB-11994 - appveyor tests on cordova-lib are ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-lib/pull/503


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib issue #503: CB-11994 - appveyor tests on cordova-lib are not tes...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:

    https://github.com/apache/cordova-lib/pull/503
  
    Yay the magic incantations have been revealed, squashing and pulling this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib issue #503: CB-11994 - appveyor tests on cordova-lib are not tes...

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/503
  
    ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/503?src=pr) is 80.40% (diff: 100%)
    > Merging [#503](https://codecov.io/gh/apache/cordova-lib/pull/503?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will not change coverage
    
    ```diff
    @@             master       #503   diff @@
    ==========================================
      Files            67         67          
      Lines          5189       5189          
      Methods         836        836          
      Messages          0          0          
      Branches       1005       1005          
    ==========================================
      Hits           4172       4172          
      Misses         1017       1017          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last update [c44db3d...784d9ab](https://codecov.io/gh/apache/cordova-lib/compare/c44db3d7a00779d5c7eb5ae6150847156858a4f7...784d9abb38ed4da1fc73e9532b58e6f44e75dfa2?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org