You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/07/25 14:23:10 UTC
[GitHub] [rocketmq-externals] StyleTang opened a new pull request #757: [ISSUE #756] [RocketMQ-Console] Improve message trace UI
StyleTang opened a new pull request #757:
URL: https://github.com/apache/rocketmq-externals/pull/757
## What is the purpose of the change
improve message trace UI
## Brief changelog
* Change Send Message Info UI
* Handle edge case: consume trace subBefore or subAfter trace is missing (if subAfter trace is missing, the status will be unknown)
* Fix timestamp typo
* Time format for ms
* Change costTime color from white to black
* Remove graph and data format button
* Fix message trace graph when producer send message cost time < 1 ms
## Verifying this change
### MessageTraceUIChange
### Handle edge case
#### Only subBefore message trace commit succeed
#### Only subAfter message trace commit succeed
### When producer send message cost time < 1 ms
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling merged pull request #757: [ISSUE #756] [RocketMQ-Console] Improve message trace UI
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #757:
URL: https://github.com/apache/rocketmq-externals/pull/757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] StyleTang commented on pull request #757: [ISSUE #756] [RocketMQ-Console] Improve message trace UI
Posted by GitBox <gi...@apache.org>.
StyleTang commented on pull request #757:
URL: https://github.com/apache/rocketmq-externals/pull/757#issuecomment-887503504
In my local environment sometimes the send message latency will less than 1ms, but in real environment there will have network latency, may be > 1ms. Not sure whether we should change the precision from milliseconds to microseconds, for now I will just keep using milliseconds.
The user experience of this commit is like this:
1. If can not get costTime, **no cost time will show** in the graph, will use **--** in data table (For transaction trace and consume message trace which subAfter is missing)
2. For cost time is 0ms, we just show **<1ms**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] StyleTang commented on pull request #757: [ISSUE #756] [RocketMQ-Console] Improve message trace UI
Posted by GitBox <gi...@apache.org>.
StyleTang commented on pull request #757:
URL: https://github.com/apache/rocketmq-externals/pull/757#issuecomment-886761558
Yes, I will investigate it and find a better way to show it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling commented on pull request #757: [ISSUE #756] [RocketMQ-Console] Improve message trace UI
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #757:
URL: https://github.com/apache/rocketmq-externals/pull/757#issuecomment-886364823
Do we have a better way to handle the 0ms which showed in our screenshot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org