You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kibble.apache.org by GitBox <gi...@apache.org> on 2020/10/25 16:34:23 UTC

[GitHub] [kibble] michalslowikowski00 opened a new issue #81: Introduce Mypy in pre-commit

michalslowikowski00 opened a new issue #81:
URL: https://github.com/apache/kibble/issues/81


   **Description**
   Add Mypy in pre-commit.
   https://mypy.readthedocs.io/en/stable/ 
   
   **Use case**
   We would like to keep our code clean and tidy -- that's why setting up Mypy in pre-commit is a good idea.
   
   **Related Issues**
   N/A
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kibble] michalslowikowski00 commented on issue #81: Introduce Mypy in pre-commit

Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on issue #81:
URL: https://github.com/apache/kibble/issues/81#issuecomment-716180706


   What do you think about flake8 also?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kibble] turbaszek commented on issue #81: Introduce Mypy in pre-commit

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #81:
URL: https://github.com/apache/kibble/issues/81#issuecomment-716178602


   +1 for this and I think @Humbedooh also likes the type hints!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kibble] turbaszek commented on issue #81: Introduce Mypy in pre-commit

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #81:
URL: https://github.com/apache/kibble/issues/81#issuecomment-716181677


   I think that if we introduce pylint #55 then we don't need flake8. We are also using black and flake8 is not always ok with black formatting - and it doesn't format the code automatically 😉 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org