You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/21 12:52:48 UTC
[GitHub] [spark] sarutak opened a new pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
sarutak opened a new pull request #32274:
URL: https://github.com/apache/spark/pull/32274
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to add linter for JavaScript source files.
[ESLint](https://eslint.org/) seems to be a popular linter for JavaScript so I choose it.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Linter enables us to check style and keeps code clean.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Manually run `dev/lint-js` (Node.js and npm are required).
NOTE: This PR only adds linter support. Style errors will be fixed in the followup PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824045323
**[Test build #137736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137736/testReport)** for PR 32274 at commit [`e2fcd9e`](https://github.com/apache/spark/commit/e2fcd9eb534f440f8b0df56f0bb04ec0db7ed80e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833578205
**[Test build #138207 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138207/testReport)** for PR 32274 at commit [`d174384`](https://github.com/apache/spark/commit/d174384b0528f3e85d02bb8c316c9ff117655c42).
* This patch passes all tests.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824541702
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137762/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826265713
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137903/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-825798626
Does all the current JS pass the linter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833501330
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42729/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824505645
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42289/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824484952
**[Test build #137762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137762/testReport)** for PR 32274 at commit [`990e538`](https://github.com/apache/spark/commit/990e538c6a35c764e1afb9bb25d2ce95b23d69c4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826250432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826240097
**[Test build #137903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137903/testReport)** for PR 32274 at commit [`d6eb61a`](https://github.com/apache/spark/commit/d6eb61aa147e2094b0cec6c2a7df829a65520685).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #32274:
URL: https://github.com/apache/spark/pull/32274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833501330
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42729/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty commented on a change in pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
kyoty commented on a change in pull request #32274:
URL: https://github.com/apache/spark/pull/32274#discussion_r618947013
##########
File path: dev/lint-js
##########
@@ -0,0 +1,55 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+set -o pipefail
+
+SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
+SPARK_ROOT_DIR="$(dirname $SCRIPT_DIR)"
+LINT_JS_REPORT_FILE_NAME="$SPARK_ROOT_DIR/dev/lint-js-report.log"
+LINT_TARGET_FILES=(
+ "$SPARK_ROOT_DIR/core/src/main/resources/org/apache/spark/ui/static/"
+ "$SPARK_ROOT_DIR/sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/"
Review comment:
I'm just curious, should the dir: `$SPARK_ROOT_DIR/docs/js/" be added to the `LINT_TARGET_FILES` ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833502673
**[Test build #138210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138210/testReport)** for PR 32274 at commit [`5bda9fc`](https://github.com/apache/spark/commit/5bda9fc225e538f883c4da5cdc50b4afa95178fb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833591876
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138207/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826240097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826250997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824179648
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137736/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833638268
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138210/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824088614
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42263/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824079877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824484952
**[Test build #137762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137762/testReport)** for PR 32274 at commit [`990e538`](https://github.com/apache/spark/commit/990e538c6a35c764e1afb9bb25d2ce95b23d69c4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833545786
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42732/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824088614
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42263/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833495465
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42729/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833591876
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138207/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826265713
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137903/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824177579
**[Test build #137736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137736/testReport)** for PR 32274 at commit [`e2fcd9e`](https://github.com/apache/spark/commit/e2fcd9eb534f440f8b0df56f0bb04ec0db7ed80e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833545786
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42732/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824505622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826043802
@srowen
> Does all the current JS pass the linter?
As I noted in the description, not yet.
I'd like to build a consensus on the basic lint rule in this PR, then I'll fix style based on the rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826250997
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42428/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty commented on a change in pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
kyoty commented on a change in pull request #32274:
URL: https://github.com/apache/spark/pull/32274#discussion_r618947013
##########
File path: dev/lint-js
##########
@@ -0,0 +1,55 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+set -o pipefail
+
+SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
+SPARK_ROOT_DIR="$(dirname $SCRIPT_DIR)"
+LINT_JS_REPORT_FILE_NAME="$SPARK_ROOT_DIR/dev/lint-js-report.log"
+LINT_TARGET_FILES=(
+ "$SPARK_ROOT_DIR/core/src/main/resources/org/apache/spark/ui/static/"
+ "$SPARK_ROOT_DIR/sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/"
Review comment:
I'm just curious, should the dir: `$SPARK_ROOT_DIR/docs/js/" be added to the `LINT_TARGET_FILES`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833493683
@srowen I fixed style based on the current rule and now the linter passes.
Too much style changes included in this PR, so if it's better to do, I'll focus on the linter and separate style change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824505645
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42289/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826240097
**[Test build #137903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137903/testReport)** for PR 32274 at commit [`d6eb61a`](https://github.com/apache/spark/commit/d6eb61aa147e2094b0cec6c2a7df829a65520685).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824538358
**[Test build #137762 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137762/testReport)** for PR 32274 at commit [`990e538`](https://github.com/apache/spark/commit/990e538c6a35c764e1afb9bb25d2ce95b23d69c4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833536041
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42732/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833467270
**[Test build #138207 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138207/testReport)** for PR 32274 at commit [`d174384`](https://github.com/apache/spark/commit/d174384b0528f3e85d02bb8c316c9ff117655c42).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-834355804
Merged to `master`. Thank you all.
I'll add this linter to the GA later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833467270
**[Test build #138207 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138207/testReport)** for PR 32274 at commit [`d174384`](https://github.com/apache/spark/commit/d174384b0528f3e85d02bb8c316c9ff117655c42).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833502673
**[Test build #138210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138210/testReport)** for PR 32274 at commit [`5bda9fc`](https://github.com/apache/spark/commit/5bda9fc225e538f883c4da5cdc50b4afa95178fb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826250997
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42428/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833498405
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42729/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824541702
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137762/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824045323
**[Test build #137736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137736/testReport)** for PR 32274 at commit [`e2fcd9e`](https://github.com/apache/spark/commit/e2fcd9eb534f440f8b0df56f0bb04ec0db7ed80e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #32274:
URL: https://github.com/apache/spark/pull/32274#discussion_r619598755
##########
File path: dev/lint-js
##########
@@ -0,0 +1,55 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+set -o pipefail
+
+SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
+SPARK_ROOT_DIR="$(dirname $SCRIPT_DIR)"
+LINT_JS_REPORT_FILE_NAME="$SPARK_ROOT_DIR/dev/lint-js-report.log"
+LINT_TARGET_FILES=(
+ "$SPARK_ROOT_DIR/core/src/main/resources/org/apache/spark/ui/static/"
+ "$SPARK_ROOT_DIR/sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/"
Review comment:
Hmm, it seems that some files should be checked. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826240097
**[Test build #137903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137903/testReport)** for PR 32274 at commit [`d6eb61a`](https://github.com/apache/spark/commit/d6eb61aa147e2094b0cec6c2a7df829a65520685).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826262491
**[Test build #137903 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137903/testReport)** for PR 32274 at commit [`d6eb61a`](https://github.com/apache/spark/commit/d6eb61aa147e2094b0cec6c2a7df829a65520685).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-824179648
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137736/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-826250997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833613769
**[Test build #138210 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138210/testReport)** for PR 32274 at commit [`5bda9fc`](https://github.com/apache/spark/commit/5bda9fc225e538f883c4da5cdc50b4afa95178fb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32274: [SPARK-35175][BUILD] Add linter for JavaScript source files.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32274:
URL: https://github.com/apache/spark/pull/32274#issuecomment-833638268
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138210/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org