You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2016/03/17 18:45:33 UTC

[GitHub] couchdb-couch pull request: Use couch_tests applications for couch...

GitHub user iilyak opened a pull request:

    https://github.com/apache/couchdb-couch/pull/154

    Use couch_tests applications for couch_db_plugin_tests

    This fixes the problem with chttpd_plugin_tests. Previously following would fail:
    ```
    make eunit apps=couch,chttpd tests=callback_test,error_info_test
    ```
    In order to test this PR you would need to add apache/couchdb-erlang-tests#1 as a dependency in `rebar.config.script`. You might need to add the app into `rel/reltool.config` as well.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch fix-couch_db_plugin_tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
    
----
commit 2a7387c6009c147bf7a5901345bd3239df70d1e0
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date:   2016-03-17T17:43:43Z

    Use couch_tests applications for couch_db_plugin_tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Use couch_tests applications for couch...

Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-couch/pull/154#issuecomment-199451992
  
    Right. +1 here as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Use couch_tests applications for couch...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-couch/pull/154


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Use couch_tests applications for couch...

Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on the pull request:

    https://github.com/apache/couchdb-couch/pull/154#issuecomment-199360834
  
    @kxepal: This one is the same change as in https://github.com/apache/couchdb-chttpd/pull/108 (which you already review).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---