You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/04/20 08:45:30 UTC
[GitHub] [doris] jackwener opened a new pull request, #18856: [enhance](Nereids): When requiredSlots is empty, prune child previously in ColumnPruning
jackwener opened a new pull request, #18856:
URL: https://github.com/apache/doris/pull/18856
# Proposed changes
Issue Number: close #xxx
## Problem summary
When requiredSlots is empty, prune child previously in ColumnPruning.
A example:
Agg count(*)
- Filter age > 3
-- Scan id, age
We should get
Agg count(*)
- Project age
-- Filter age > 3
--- Scan id, age
instead of
Agg count(*)
- Project age, id
-- Filter age > 3
--- Scan id, age
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on pull request #18856: [enhance](Nereids): When requiredSlots is empty, prune child previously in ColumnPruning
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on PR #18856:
URL: https://github.com/apache/doris/pull/18856#issuecomment-1516127837
column pruning has lots of special cases, and can not image all of the cases, so I can not review this pr.
but in my experience, this code more likely make the regression test, because I remember that I've write the code like you and failed.
when you run into the bug, you can unify abstraction and modification based on all known cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener closed pull request #18856: [enhance](Nereids): When requiredSlots is empty, prune child previously in ColumnPruning
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener closed pull request #18856: [enhance](Nereids): When requiredSlots is empty, prune child previously in ColumnPruning
URL: https://github.com/apache/doris/pull/18856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org