You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/07/12 21:59:54 UTC

[GitHub] [singa] joddiy edited a comment on pull request #760: Scatter

joddiy edited a comment on pull request #760:
URL: https://github.com/apache/singa/pull/760#issuecomment-657281203


   Please check my PR:
   
   https://github.com/Shashankwer/singa/pull/1
   
   For the arguments of forward function, we should only contain the argument which has a gradient. for example, in this operator, only x have the gradient, so we move other arguments(indices and updates) to `__init__` function.
   
   By the way, I think the advanced indexing idea is fine, could we implement it without numpy? since we will move this implement to c++ end later. Any function using the dependency will be a problem then.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org