You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by pn...@apache.org on 2019/05/07 07:44:34 UTC

[flink] 07/07: [hotfix][kafka, test] Handle shutdownCluster even if it wasn't initialized

This is an automated email from the ASF dual-hosted git repository.

pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit b20e57d29387a84c85836e62b6c02f24fefccd7c
Author: Piotr Nowojski <pi...@gmail.com>
AuthorDate: Mon Feb 11 13:39:05 2019 +0100

    [hotfix][kafka,test] Handle shutdownCluster even if it wasn't initialized
    
    Previously null pointer exception thrown from @AfterClass shutdown call could hide
    original underlying issue if there was a failure that prevented kafkaServer from being constructed
---
 .../org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java b/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
index 073ba6e..c86dd08 100644
--- a/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
+++ b/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
@@ -167,7 +167,9 @@ public abstract class KafkaTestBase extends TestLogger {
 			secureProps.clear();
 		}
 
-		kafkaServer.shutdown();
+		if (kafkaServer != null) {
+			kafkaServer.shutdown();
+		}
 	}
 
 	// ------------------------------------------------------------------------