You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/31 03:05:26 UTC
[GitHub] [airflow] dflionis opened a new pull request #13396: Allow Tags on AWS Batch Job Submission
dflionis opened a new pull request #13396:
URL: https://github.com/apache/airflow/pull/13396
**Pull Request Intention**
When submitting a job to AWS Batch, AWS allows you to provide _tags_ to help track, slice and dice costs in AWS Cost Explorer (or similar finance tools). The [boto3 Batch submit_job API](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/batch.html#Batch.Client.submit_job) allows tags to be passed but Airflow's AwsBatchOperator currently does not provide an argument for passing tags along to the boto3 API.
**Disclaimer**
This is my first Airflow pull request and I'm imagining that will show through in some form or another. I was having difficulty getting **breeze** set up locally for confirming that my code change passes all of the quality checks--therefore I am opening the PR hoping that I can use the remote CI system for confirming/iterating on ensuring this change meets the quality standard (seems like a small enough change where my ill-advised iteration cycle may suffice but we shall see π€ )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13396: Allow Tags on AWS Batch Job Submission
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13396:
URL: https://github.com/apache/airflow/pull/13396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13396: Allow Tags on AWS Batch Job Submission
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13396:
URL: https://github.com/apache/airflow/pull/13396#issuecomment-752921866
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13396: Allow Tags on AWS Batch Job Submission
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13396:
URL: https://github.com/apache/airflow/pull/13396#issuecomment-752921769
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13396: Allow Tags on AWS Batch Job Submission
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13396:
URL: https://github.com/apache/airflow/pull/13396#issuecomment-752826593
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itβs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org