You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/02 19:07:55 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #10096: ARROW-12444: [Rust] Remove rust
jorgecarleitao opened a new pull request #10096:
URL: https://github.com/apache/arrow/pull/10096
Removes rust from this repository and uses git clone to fetch the arrow-rs repo for integration tests.
Each commit is an independent change.
Note: Rust implementations have moved to:
* https://github.com/apache/arrow-rs
* https://github.com/apache/arrow-datafusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#discussion_r618391021
##########
File path: dev/archery/archery/lang/rust.py
##########
@@ -1,23 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
I am not sure this one should be removed @jorgecarleitao -- it might be how rust is run in the integration test framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10096:
URL: https://github.com/apache/arrow/pull/10096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#issuecomment-831240750
Thank you @kszucs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#issuecomment-826842743
Ok, I think it is time to merge this PR @jorgecarleitao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #10096:
URL: https://github.com/apache/arrow/pull/10096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#discussion_r622550140
##########
File path: dev/archery/archery/cli.py
##########
@@ -641,8 +640,6 @@ def _set_default(opt, default):
help='Include JavaScript in integration tests')
@click.option('--with-go', type=bool, default=False,
help='Include Go in integration tests')
-@click.option('--with-rust', type=bool, default=False,
Review comment:
This should stay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#issuecomment-822163265
https://issues.apache.org/jira/browse/ARROW-12444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#issuecomment-828739609
Rebased :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#issuecomment-830857890
Thanks @kszucs . I have applied all those changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#issuecomment-826879640
I think that we agreed over the mailing list to not merge this until @kszucs gives green light, post release.
I suggest that we take the time to complete the release, confirm that we are in a new development cycle, and then merge this. The rational being that I would like to reduce the risk of pushing merge conflicts to the release manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#issuecomment-830051964
Rust releated part should be removed from `ci/docker/linux-apt-lint.dockerfile`.
There is a reference for the rust implementation in `matlab/doc/matlab_interface_for_apache_arrow_design.md` which
should be updated.
I assume the rust post release script should be removed as well `ci/release/post-07-rust.sh` since the new releases will be cut from `arrow-rs`.
There is a `debian-rust` configuration in the docker compose as well as in the crossbow tasks, but I guess we can keep that around to exercise the rust build script for the integration tests on a nightly basis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#issuecomment-827061108
Yes, please hold off until we merge #10165.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on a change in pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#discussion_r618402563
##########
File path: dev/archery/archery/lang/rust.py
##########
@@ -1,23 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
AFAIK this was only used to call `Cargo fmt` from Python; the build of the integration binaries is done by `rust_build.sh`; Python calls those binaries without `Cargo`.
I also checking [the logs](https://github.com/apache/arrow/pull/10096/checks?check_run_id=2377696454), we can find prints such as
```
##########################################################
IPC: C++ producing, Rust consuming
##########################################################
```
indicating that Rust is being tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#issuecomment-831197954
Thanks @jorgecarleitao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10096: ARROW-12444: [Rust] Remove rust
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10096:
URL: https://github.com/apache/arrow/pull/10096#issuecomment-830046460
@jorgecarleitao @andygrove @alamb I think we can start to roll-up the rust pull requests now. There are a couple of open ones remaining, I assume we should close those and merge this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org