You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2019/03/27 05:11:22 UTC
[bookkeeper] branch master updated: Fix error message for
unrecognized number-of-bookies
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new e35a108 Fix error message for unrecognized number-of-bookies
e35a108 is described below
commit e35a108c7a47d746d5010ee5178712496741cc18
Author: Like <li...@163.com>
AuthorDate: Wed Mar 27 13:11:17 2019 +0800
Fix error message for unrecognized number-of-bookies
Closes #1925
Reviewers: Enrico Olivelli <eo...@gmail.com>, Sijie Guo <si...@apache.org>
This closes #1997 from liketic/fix-issue-1925
---
.../java/org/apache/bookkeeper/util/LocalBookKeeper.java | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java
index e431e8e..97884a6 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java
@@ -428,25 +428,32 @@ public class LocalBookKeeper {
Iterator<String> keys = localBookieConfig.getKeys();
try (PrintWriter writer = new PrintWriter(localBookieConfFile, "UTF-8")) {
while (keys.hasNext()) {
- String key = keys.next().toString();
+ String key = keys.next();
String[] values = localBookieConfig.getStringArray(key);
StringBuilder concatenatedValue = new StringBuilder(values[0]);
for (int i = 1; i < values.length; i++) {
- concatenatedValue.append("," + values[i]);
+ concatenatedValue.append(",").append(values[i]);
}
writer.println(key + "=" + concatenatedValue.toString());
}
}
}
- public static void main(String[] args) throws Exception, SecurityException {
+ public static void main(String[] args) {
try {
if (args.length < 1) {
usage();
System.exit(-1);
}
- int numBookies = Integer.parseInt(args[0]);
+ int numBookies = 0;
+ try {
+ numBookies = Integer.parseInt(args[0]);
+ } catch (NumberFormatException nfe) {
+ LOG.error("Unrecognized number-of-bookies: {}", args[0]);
+ usage();
+ System.exit(-1);
+ }
ServerConfiguration conf = new ServerConfiguration();
conf.setAllowLoopback(true);