You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@gmail.com> on 2013/09/21 22:06:48 UTC

[PATCH] proxy API to indicate if connection is potentially reusable (for proxy_fcgi)

http://people.apache.org/~trawick/check_proxy_connection_reusable_r1.txt

proxy_fcgi should only turn on AP_FCGI_KEEP_CONN if it is possible to reuse
the connection again.  There are several issues to consider in the proxy
connection and worker structures to see if the connection is potentially
reusable.

Is the API in the patch referenced above reasonable?  (I'm largely ignorant
of any subtleties around reuse.)

Also, I'm ignoring the fact that conn->close is hard-coded to 1 elsewhere
in mod_proxy_fcgi.  Rather than hard code AP_FCGI_KEEP_CONN off to match,
I'd rather let this particular mod_proxy_fcgi code do the right thing
regardless.

TIA!

-- 
Born in Roswell... married an alien...
http://emptyhammock.com/

Re: [PATCH] proxy API to indicate if connection is potentially reusable (for proxy_fcgi)

Posted by Jeff Trawick <tr...@gmail.com>.
On Mon, Sep 23, 2013 at 9:40 AM, Jim Jagielski <ji...@jagunet.com> wrote:

> Looks good birthday boy!
> On Sep 21, 2013, at 4:06 PM, Jeff Trawick <tr...@gmail.com> wrote:
>
> > http://people.apache.org/~trawick/check_proxy_connection_reusable_r1.txt
> >
> > proxy_fcgi should only turn on AP_FCGI_KEEP_CONN if it is possible to
> reuse the connection again.  There are several issues to consider in the
> proxy connection and worker structures to see if the connection is
> potentially reusable.
> >
> > Is the API in the patch referenced above reasonable?  (I'm largely
> ignorant of any subtleties around reuse.)
> >
> > Also, I'm ignoring the fact that conn->close is hard-coded to 1
> elsewhere in mod_proxy_fcgi.  Rather than hard code AP_FCGI_KEEP_CONN off
> to match, I'd rather let this particular mod_proxy_fcgi code do the right
> thing regardless.
> >
> > TIA!
>

Thanks for looking, guys!


> >
> > --
> > Born in Roswell... married an alien...
> > http://emptyhammock.com/
>
>


-- 
Born in Roswell... married an alien...
http://emptyhammock.com/

Re: [PATCH] proxy API to indicate if connection is potentially reusable (for proxy_fcgi)

Posted by Jim Jagielski <ji...@jaguNET.com>.
Looks good birthday boy!
On Sep 21, 2013, at 4:06 PM, Jeff Trawick <tr...@gmail.com> wrote:

> http://people.apache.org/~trawick/check_proxy_connection_reusable_r1.txt
> 
> proxy_fcgi should only turn on AP_FCGI_KEEP_CONN if it is possible to reuse the connection again.  There are several issues to consider in the proxy connection and worker structures to see if the connection is potentially reusable.
> 
> Is the API in the patch referenced above reasonable?  (I'm largely ignorant of any subtleties around reuse.)
> 
> Also, I'm ignoring the fact that conn->close is hard-coded to 1 elsewhere in mod_proxy_fcgi.  Rather than hard code AP_FCGI_KEEP_CONN off to match, I'd rather let this particular mod_proxy_fcgi code do the right thing regardless.
> 
> TIA!
> 
> -- 
> Born in Roswell... married an alien...
> http://emptyhammock.com/

RE: [PATCH] proxy API to indicate if connection is potentially reusable (for proxy_fcgi)

Posted by Plüm, Rüdiger, Vodafone Group <ru...@vodafone.com>.
Looks good.

Regards

Rüdiger

From: Jeff Trawick [mailto:trawick@gmail.com]
Sent: Samstag, 21. September 2013 22:07
To: Apache HTTP Server Development List
Subject: [PATCH] proxy API to indicate if connection is potentially reusable (for proxy_fcgi)

http://people.apache.org/~trawick/check_proxy_connection_reusable_r1.txt

proxy_fcgi should only turn on AP_FCGI_KEEP_CONN if it is possible to reuse the connection again.  There are several issues to consider in the proxy connection and worker structures to see if the connection is potentially reusable.

Is the API in the patch referenced above reasonable?  (I'm largely ignorant of any subtleties around reuse.)

Also, I'm ignoring the fact that conn->close is hard-coded to 1 elsewhere in mod_proxy_fcgi.  Rather than hard code AP_FCGI_KEEP_CONN off to match, I'd rather let this particular mod_proxy_fcgi code do the right thing regardless.

TIA!

--
Born in Roswell... married an alien...
http://emptyhammock.com/