You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org> on 2009/07/20 15:35:14 UTC
[jira] Created: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
FLE should perform leader check when node is not leading and add vote of follower
---------------------------------------------------------------------------------
Key: ZOOKEEPER-480
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
Project: Zookeeper
Issue Type: Bug
Reporter: Flavio Paiva Junqueira
Fix For: 3.2.1
As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737072#action_12737072 ]
Hadoop QA commented on ZOOKEEPER-480:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12414159/ZOOKEEPER-480.patch
against trunk revision 798038.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/159/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/159/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/159/console
This message is automatically generated.
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-480:
-----------------------------------
Status: Patch Available (was: Open)
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-480:
-----------------------------------
Affects Version/s: 3.2.0
Fix Version/s: 3.3.0
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-480:
---------------------------------------------
Status: Open (was: Patch Available)
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-480:
------------------------------------
Status: Open (was: Patch Available)
flavio, the patch does not apply any more after ZOOKEEPER-481 commit. can you please update the patch?
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-480:
---------------------------------------------
Attachment: ZOOKEEPER-480-3.2branch.patch
Uploading the 3.2 version of the patch.
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-480:
---------------------------------------------
Attachment: ZOOKEEPER-480.patch
* Adds a case to leader election to recover from a lost message when one single follower elects a leader, but the leader missed the new vote from the follower. This is not a really critical case because in practice the servers would just move to a new round of leader election, and the likelihood that this keeps happening forever is small;
* It adds a unit test that basically mocks a server to force a particular sequence and interleaving of messages;
* It makes some methods and variables public in QuorumCnxManager to enable the unit test to access them directly.
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Flavio Paiva Junqueira
> Fix For: 3.2.1
>
> Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-480:
---------------------------------------------
Attachment: ZOOKEEPER-480.patch
Added the comment Ben suggested. Thanks, Ben.
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar resolved ZOOKEEPER-480.
-------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
I just committed this. thanks flavio.
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-480:
-----------------------------------
Status: Open (was: Patch Available)
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-480:
---------------------------------------------
Status: Patch Available (was: Open)
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Flavio Paiva Junqueira
> Fix For: 3.2.1
>
> Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-480:
---------------------------------------------
Status: Patch Available (was: Open)
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-480:
--------------------------------------
Assignee: Flavio Paiva Junqueira
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1
>
> Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-480:
---------------------------------------------
Attachment: ZOOKEEPER-480.patch
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Flavio Paiva Junqueira
> Fix For: 3.2.1
>
> Attachments: ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739427#action_12739427 ]
Hudson commented on ZOOKEEPER-480:
----------------------------------
Integrated in ZooKeeper-trunk #405 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/405/])
. FLE should perform leader check when node is not leading and add vote of follower (flavio via mahadev)
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738732#action_12738732 ]
Mahadev konar commented on ZOOKEEPER-480:
-----------------------------------------
flavio, canm you upload 3.2 patch as well?
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-480:
---------------------------------------------
Attachment: ZOOKEEPER-480.patch
Regenerated patch to apply to trunk. Will be posting a new patch for 3.2 trunk shortly.
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-480:
---------------------------------------------
Status: Open (was: Patch Available)
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-480:
---------------------------------------------
Status: Patch Available (was: Open)
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737221#action_12737221 ]
Benjamin Reed commented on ZOOKEEPER-480:
-----------------------------------------
looks great flavio. i think i figured out how the test works. do you mind putting a comment into the test to state your strategy for posterity?
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-480:
---------------------------------------------
Attachment: ZOOKEEPER-480.patch
Small modification to port assignment in the test, re-running to make sure that still passes all tests.
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check
when node is not leading and add vote of follower
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-480:
---------------------------------------------
Attachment: ZOOKEEPER-480-3.2branch.patch
Patch for 3.2 branch.
> FLE should perform leader check when node is not leading and add vote of follower
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-480
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch
>
>
> As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails.
> This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.