[GitHub] [helix] alirezazamani commented on a change in pull request #1468: Implement deleteTask API

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #1468:
URL: https://github.com/apache/helix/pull/1468#discussion_r506969537



##########
File path: helix-core/src/test/java/org/apache/helix/integration/task/TestAddDeleteTask.java
##########
@@ -89,9 +100,16 @@ public void testAddJobMissing() throws Exception {
     } catch (IllegalArgumentException e) {
       // Helix Exception is expected because job config is missing
     }
+
+    try {
+      _driver.deleteTask(workflowName, jobName, task.getId());
+      Assert.fail("Exception is expected because job config is missing");
+    } catch (IllegalArgumentException e) {
+      // Helix Exception is expected because job config is missing

Review comment:
       Good catch. Let me fix the comments.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org