You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/09 11:31:17 UTC
[GitHub] [superset] geido commented on a change in pull request #16454: feat: add certifiedby & certification details fields to the edit dataset columns fields
geido commented on a change in pull request #16454:
URL: https://github.com/apache/superset/pull/16454#discussion_r705238839
##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -235,6 +243,26 @@ function ColumnCollectionTable({
/>
}
/>
+ <Field
+ fieldKey="certified_by"
+ label={t('Certified By')}
+ control={
+ <TextControl
+ controlId="certified"
+ placeholder={t('Certified By')}
+ />
+ }
+ />
+ <Field
+ fieldKey="certification_details"
+ label={t('Certification Details')}
Review comment:
```suggestion
label={t('Certification details')}
```
##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -235,6 +243,26 @@ function ColumnCollectionTable({
/>
}
/>
+ <Field
+ fieldKey="certified_by"
+ label={t('Certified By')}
+ control={
+ <TextControl
+ controlId="certified"
+ placeholder={t('Certified By')}
+ />
+ }
+ />
+ <Field
+ fieldKey="certification_details"
+ label={t('Certification Details')}
+ control={
+ <TextControl
+ controlId="certificationDetails"
+ placeholder={t('Certification Details')}
Review comment:
```suggestion
placeholder={t('Certification details')}
```
##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -235,6 +243,26 @@ function ColumnCollectionTable({
/>
}
/>
+ <Field
+ fieldKey="certified_by"
+ label={t('Certified By')}
+ control={
+ <TextControl
+ controlId="certified"
+ placeholder={t('Certified By')}
Review comment:
```suggestion
placeholder={t('Certified by')}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org