You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Fedotov (JIRA)" <ji...@apache.org> on 2007/10/02 11:34:50 UTC

[jira] Created: (HARMONY-4882) [vm][gc] vm throws an assertion when array size is big

[vm][gc] vm throws an assertion when array size is big
------------------------------------------------------

                 Key: HARMONY-4882
                 URL: https://issues.apache.org/jira/browse/HARMONY-4882
             Project: Harmony
          Issue Type: Bug
          Components: DRLVM
            Reporter: Alexei Fedotov


The following line produce an assertion in VM code:

Class.h:
    unsigned calculate_array_size(int length) const {
        [...]
        assert((size & NEXT_TO_HIGH_BIT_SET_MASK) == 0); <<< crash
        return size;
    }

The VM should not crash. It should behave according to spec: if it cannot allocate an array, it should throw OutOfMemoryError.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-4882) [drlvm][vmcore] vm throws an assertion when array size is big

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky resolved HARMONY-4882.
----------------------------------------

    Resolution: Fixed

Patch is applied at 583507. Test in HARMONY-4891 now works.

> [drlvm][vmcore] vm throws an assertion when array size is big
> -------------------------------------------------------------
>
>                 Key: HARMONY-4882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4882
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Alexei Fedotov
>            Assignee: Gregory Shimansky
>         Attachments: array_size_check_improved.patch
>
>
> The following line produce an assertion in VM code:
> Class.h:
>     unsigned calculate_array_size(int length) const {
>         [...]
>         assert((size & NEXT_TO_HIGH_BIT_SET_MASK) == 0); <<< crash
>         return size;
>     }
> The VM should not crash. It should behave according to spec: if it cannot allocate an array, it should throw OutOfMemoryError.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-4882) [drlvm][vmcore] vm throws an assertion when array size is big

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky reassigned HARMONY-4882:
------------------------------------------

    Assignee: Gregory Shimansky

> [drlvm][vmcore] vm throws an assertion when array size is big
> -------------------------------------------------------------
>
>                 Key: HARMONY-4882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4882
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Alexei Fedotov
>            Assignee: Gregory Shimansky
>         Attachments: array_size_check_improved.patch
>
>
> The following line produce an assertion in VM code:
> Class.h:
>     unsigned calculate_array_size(int length) const {
>         [...]
>         assert((size & NEXT_TO_HIGH_BIT_SET_MASK) == 0); <<< crash
>         return size;
>     }
> The VM should not crash. It should behave according to spec: if it cannot allocate an array, it should throw OutOfMemoryError.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4882) [drlvm][vmcore] vm throws an assertion when array size is big

Posted by "Xiao-Feng Li (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xiao-Feng Li updated HARMONY-4882:
----------------------------------

    Summary: [drlvm][vmcore] vm throws an assertion when array size is big  (was: [drlvm][gc] vm throws an assertion when array size is big)

Changed to a vmcore bug. Thanks, -xiaofeng

> [drlvm][vmcore] vm throws an assertion when array size is big
> -------------------------------------------------------------
>
>                 Key: HARMONY-4882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4882
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Alexei Fedotov
>         Attachments: array_size_check_improved.patch
>
>
> The following line produce an assertion in VM code:
> Class.h:
>     unsigned calculate_array_size(int length) const {
>         [...]
>         assert((size & NEXT_TO_HIGH_BIT_SET_MASK) == 0); <<< crash
>         return size;
>     }
> The VM should not crash. It should behave according to spec: if it cannot allocate an array, it should throw OutOfMemoryError.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-4882) [drlvm][vmcore] vm throws an assertion when array size is big

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky closed HARMONY-4882.
--------------------------------------


No response, assuming ok.

> [drlvm][vmcore] vm throws an assertion when array size is big
> -------------------------------------------------------------
>
>                 Key: HARMONY-4882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4882
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Alexei Fedotov
>            Assignee: Gregory Shimansky
>         Attachments: array_size_check_improved.patch
>
>
> The following line produce an assertion in VM code:
> Class.h:
>     unsigned calculate_array_size(int length) const {
>         [...]
>         assert((size & NEXT_TO_HIGH_BIT_SET_MASK) == 0); <<< crash
>         return size;
>     }
> The VM should not crash. It should behave according to spec: if it cannot allocate an array, it should throw OutOfMemoryError.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4882) [drlvm][gc] vm throws an assertion when array size is big

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-4882:
------------------------------------

    Summary: [drlvm][gc] vm throws an assertion when array size is big  (was: [vm][gc] vm throws an assertion when array size is big)

> [drlvm][gc] vm throws an assertion when array size is big
> ---------------------------------------------------------
>
>                 Key: HARMONY-4882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4882
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Alexei Fedotov
>
> The following line produce an assertion in VM code:
> Class.h:
>     unsigned calculate_array_size(int length) const {
>         [...]
>         assert((size & NEXT_TO_HIGH_BIT_SET_MASK) == 0); <<< crash
>         return size;
>     }
> The VM should not crash. It should behave according to spec: if it cannot allocate an array, it should throw OutOfMemoryError.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4882) [drlvm][gc] vm throws an assertion when array size is big

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-4882:
------------------------------------

    Patch Info: [Patch Available]

> [drlvm][gc] vm throws an assertion when array size is big
> ---------------------------------------------------------
>
>                 Key: HARMONY-4882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4882
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Alexei Fedotov
>         Attachments: array_size_check_improved.patch
>
>
> The following line produce an assertion in VM code:
> Class.h:
>     unsigned calculate_array_size(int length) const {
>         [...]
>         assert((size & NEXT_TO_HIGH_BIT_SET_MASK) == 0); <<< crash
>         return size;
>     }
> The VM should not crash. It should behave according to spec: if it cannot allocate an array, it should throw OutOfMemoryError.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4882) [drlvm][gc] vm throws an assertion when array size is big

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-4882:
------------------------------------

    Attachment: array_size_check_improved.patch

Here is the fix for condition.

> [drlvm][gc] vm throws an assertion when array size is big
> ---------------------------------------------------------
>
>                 Key: HARMONY-4882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4882
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Alexei Fedotov
>         Attachments: array_size_check_improved.patch
>
>
> The following line produce an assertion in VM code:
> Class.h:
>     unsigned calculate_array_size(int length) const {
>         [...]
>         assert((size & NEXT_TO_HIGH_BIT_SET_MASK) == 0); <<< crash
>         return size;
>     }
> The VM should not crash. It should behave according to spec: if it cannot allocate an array, it should throw OutOfMemoryError.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4882) [drlvm][gc] vm throws an assertion when array size is big

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531773 ] 

Alexei Fedotov commented on HARMONY-4882:
-----------------------------------------

The local problem is incorrect conditional which precedes the assertion. There might be more problems along this code branch which was never taken before. 

> [drlvm][gc] vm throws an assertion when array size is big
> ---------------------------------------------------------
>
>                 Key: HARMONY-4882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4882
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Alexei Fedotov
>
> The following line produce an assertion in VM code:
> Class.h:
>     unsigned calculate_array_size(int length) const {
>         [...]
>         assert((size & NEXT_TO_HIGH_BIT_SET_MASK) == 0); <<< crash
>         return size;
>     }
> The VM should not crash. It should behave according to spec: if it cannot allocate an array, it should throw OutOfMemoryError.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.