You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/12/23 03:27:12 UTC
[GitHub] zeppelin pull request #1796: [WIP] ZEPPELIN-1852. Use multiple InterpreterRe...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/1796
[WIP] ZEPPELIN-1852. Use multiple InterpreterResult for displaying appInfo
### What is this PR for?
Refactor the livy interpreter to use multiple `InterpreterResult` for displaying appInfo.
### What type of PR is it?
[Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1852
### How should this be tested?
Add integration test and also test it manually
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1852
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1796.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1796
----
commit e800932d9070e9c82b96802592ae4a6a0cfe0000
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-12-23T03:14:32Z
ZEPPELIN-1851. LazyOpenInterpreter would open interpreter multiple times when open fails
commit e34e4f52d3510fc2a6233a580f7d21cda6a98476
Author: Jeff Zhang <zj...@apache.org>
Date: 2016-12-23T03:24:27Z
ZEPPELIN-1852. Use multiple InterpreterResult for displaying appInfo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1796: ZEPPELIN-1852. Use multiple InterpreterResult for disp...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1796
LGTM - let's check CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1796: ZEPPELIN-1852. Use multiple InterpreterResult for disp...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1796
CI is green. Will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1796: [WIP] ZEPPELIN-1852. Use multiple InterpreterResult fo...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1796
This PR also contains the fix of #1795 , I will update it after #1795 is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1796: [WIP] ZEPPELIN-1852. Use multiple InterpreterResult fo...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1796
Thanks @prabhjyotsingh , because I think it make more sense to name it as `zeppelin.livy.session.create_timeout`, doc is updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1796: ZEPPELIN-1852. Use multiple InterpreterResult for disp...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1796
CI was green I think https://travis-ci.org/apache/zeppelin/builds/189432940
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1796: [WIP] ZEPPELIN-1852. Use multiple InterpreterResult fo...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1796
Rest LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1796: [WIP] ZEPPELIN-1852. Use multiple InterpreterResult fo...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1796
Any specific reason you want to change `livy.create.session.timeout` ? You may want to update this https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/livy.html doc as well.
\U0001f44d for adding test case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1796: [WIP] ZEPPELIN-1852. Use multiple InterpreterResult fo...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1796
@Leemoonsoo Please help review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1796: ZEPPELIN-1852. Use multiple InterpreterResult f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1796
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1796: ZEPPELIN-1852. Use multiple InterpreterResult for disp...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1796
@jongyoul @felixcheung Could you help merge it into branch-0.7 and master ? CI failure is not relevant.
```
Failed tests:
NotebookTest.testAbortParagraphStatusOnInterpreterRestart:760 expected:<ABORT> but was:<RUNNING>
WelcomePageSuite:
- Welcome sign is correct *** FAILED ***
The code passed to eventually never returned normally. Attempted 19 times over 20.868011947 seconds. Last failure message: WelcomePageSuite.this.find("welcome")(WelcomePageSuite.this.driver).isDefined was false. (WelcomePageSuite.scala:31)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---