[GitHub] [skywalking-showcase] kezhenxu94 commented on a change in pull request #6: Activate all components in default and polish doc

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #6:
URL: https://github.com/apache/skywalking-showcase/pull/6#discussion_r750825163



##########
File path: docs/readme.md
##########
@@ -32,15 +32,19 @@ Make sure you have a running Kubernetes cluster and `kubectl` can access to that
 ```shell
 git clone https://github.com/apache/skywalking-showcase.git
 cd skywalking-showcase
-make deploy.kubernetes FEATURE_FLAGS=cluster,agent,vm,so11y
+make deploy.kubernetes
 ```
 
 This will install SkyWalking components, including OAP in cluster mode with 2 nodes, SkyWalking RocketBot UI,
-microservices with SkyWalking agent, 2 Pods to mimic virtual machines and export metrics to SkyWalking, and enable
-SkyWalking self observability metrics.
+microservices with SkyWalking agent, microservices without SkyWalking agent but managed by Istio, 
+2 Pods to mimic virtual machines and export metrics to SkyWalking, and enable kubernetes cluster monitoring as well as 
+SkyWalking self observability.
 
 For more advanced deployments, check [Customization](#customization) documentation below.
 
+Notice, when run this showcase locally such as KinD, the images are downloaded inside the KinD, which could take over 10 mins(depend on local network).
+Rerun `make deploy.kubernetes` if some timeout errors break the process.

Review comment:
       ```suggestion
   Notice, when running this showcase locally such as KinD, the images are downloaded inside the KinD, which could take over 10 minutes (depending on the local network).
   Rerun `make deploy.kubernetes` until the command succeeds if there are timeout errors breaking the process.
   ```

##########
File path: docs/readme.md
##########
@@ -32,15 +32,19 @@ Make sure you have a running Kubernetes cluster and `kubectl` can access to that
 ```shell
 git clone https://github.com/apache/skywalking-showcase.git
 cd skywalking-showcase
-make deploy.kubernetes FEATURE_FLAGS=cluster,agent,vm,so11y
+make deploy.kubernetes
 ```
 
 This will install SkyWalking components, including OAP in cluster mode with 2 nodes, SkyWalking RocketBot UI,
-microservices with SkyWalking agent, 2 Pods to mimic virtual machines and export metrics to SkyWalking, and enable
-SkyWalking self observability metrics.
+microservices with SkyWalking agent, microservices without SkyWalking agent but managed by Istio, 
+2 Pods to mimic virtual machines and export metrics to SkyWalking, and enable kubernetes cluster monitoring as well as 

Review comment:
       ```suggestion
   2 Pods to mimic virtual machines and export metrics to SkyWalking, and enable Kubernetes cluster monitoring as well as 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org