[jira] Commented: (MNG-2691) DefaultPluginManager.addPlugin() doesn't tell which plugin is broken

["Aaron Digulla (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MNG-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=129787#action_129787 ] 

Aaron Digulla commented on MNG-2691:
------------------------------------

I think this bug is fixed in 2.0.8 but there is a new issue: I get this error with the maven-site-plugin 2.0-beta-6:

[code]
[DEBUG] maven-site-plugin: resolved to version 2.0-beta-6 from repository central
[DEBUG] Retrieving parent-POM: org.apache.maven.plugins:maven-plugins::10 for project: null:maven-site-plugin:maven-plugin:2.0-beta-6 from the repository.
[DEBUG] Retrieving parent-POM: org.apache.maven:maven-parent::7 for project: org.apache.maven.plugins:maven-plugins:pom:10 from the repository.
[DEBUG] Retrieving parent-POM: org.apache:apache::4 for project: org.apache.maven:maven-parent:pom:7 from the repository.
[INFO] ------------------------------------------------------------------------
[ERROR] FATAL ERROR
[INFO] ------------------------------------------------------------------------
[INFO] The PluginDescriptor for the plugin Plugin [org.apache.maven.plugins:maven-site-plugin] was not found.
[INFO] ------------------------------------------------------------------------
[DEBUG] Trace
java.lang.IllegalStateException: The PluginDescriptor for the plugin Plugin [org.apache.maven.plugins:maven-site-plugin] was not found.
        at org.apache.maven.plugin.DefaultPluginManager.addPlugin(DefaultPluginManager.java:321)
        at org.apache.maven.plugin.DefaultPluginManager.verifyVersionedPlugin(DefaultPluginManager.java:208)
[code]

As you can see, the plugin exists and the POM could be loaded. So what is wrong in this case?

> DefaultPluginManager.addPlugin() doesn't tell which plugin is broken
> --------------------------------------------------------------------
>
>                 Key: MNG-2691
>                 URL: http://jira.codehaus.org/browse/MNG-2691
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Plugins and Lifecycle
>    Affects Versions: 2.0.5
>            Reporter: Aaron Digulla
>             Fix For: Reviewed Pending Version Assignment
>
>
> In DefaultPluginManager.addPlugin() is code like this:
> throw new IllegalStateException( "The PluginDescriptor for the plugin " + plugin + " was not found." );
> Unfortunately, "plugin" has no toString(), so you just see the Java classname and the object id.
> Replace all three places with "plugin.getKey()" or, even better, add a new method to Plugin which also includes the version string if there is one.
> Also the error message of the IllegalStateException should be:
> "The PluginDescriptor for the plugin " + plugin.getKey() + " was not found. Are you sure this is a Maven plugin and not a normal dependency?"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira