You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by mbalassi <gi...@git.apache.org> on 2016/03/13 06:44:16 UTC

[GitHub] flink pull request: [FLINK-3610][api-breaking][streaming] Introduc...

GitHub user mbalassi opened a pull request:

    https://github.com/apache/flink/pull/1784

    [FLINK-3610][api-breaking][streaming] Introduced Scala DataStreamSink

    The change is effectively already tested in `DataStreamTest`.
    
    It might make sense to introduce further testing that ensures that all the scala api method calls returning data stream variants reamin in the scala api.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mbalassi/flink FLINK-3610

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1784.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1784
    
----
commit 789af80b8a30f11da912a47a30d57e9dc8c317b1
Author: Márton Balassi <mb...@apache.org>
Date:   2016-03-13T05:29:45Z

    [FLINK-3610][api-breaking][streaming] Introduced Scala DataStreamSink

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3610][api-breaking][streaming] Introduc...

Posted by mbalassi <gi...@git.apache.org>.

Github user mbalassi closed the pull request at:

    https://github.com/apache/flink/pull/1784


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3610][api-breaking][streaming] Introduc...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1784#issuecomment-196194991
  
    This patch breaks the stable (`@Public`) API. Hence, it should not be applied for a 1.x release.
    Is returning a Java `DataStreamSink` a real problem or just an inconsistency of the API?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---