You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by LouisLWang <gi...@git.apache.org> on 2017/03/06 09:54:24 UTC
[GitHub] incubator-weex pull request #38: fix WXWebView weak reference with delegate ...
GitHub user LouisLWang opened a pull request:
https://github.com/apache/incubator-weex/pull/38
fix WXWebView weak reference with delegate when WXWebView dealloc, fi\u2026
\u2026x hit reply too quickly cause view render crash
<!--
Notes: Weex will move into Apache Software Foundation (ASF) on Feb 24 2017.
Our new GitHub repo is https://github.com/apache/incubator-weex
After Feb 24 2017, we only accept pull requests from https://github.com/apache/incubator-weex
Thank you for your support.
----
\u6ce8\u610f\uff1aWeex \u5c06\u4e8e 2017-02-24 \u8fc1\u79fb\u81f3 Apache \u57fa\u91d1\u4f1a
\u5c4a\u65f6\u6211\u4eec\u4f1a\u4f7f\u7528\u65b0\u7684 GitHub \u4ed3\u5e93\uff1ahttps://github.com/apache/incubator-weex \u5e76\u5728\u90a3\u91cc\u7ee7\u7eed\u63a5\u53d7\u5927\u5bb6\u7684 pull request\u3002
\u66f4\u591a\u8be6\u60c5\u8bf7\u5173\u6ce8\uff1ahttps://github.com/weexteam/article/issues/130
\u611f\u8c22\u7406\u89e3\u548c\u652f\u6301
-->
<!--
It's ***RECOMMENDED*** to submit typo fix, new demo and tiny bugfix to `dev` branch. New feature and other modifications can be submitted to "domain" branch including `ios`, `android`, `jsfm`, `html5`.
See [Branch Strategy](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management) for more detail.
----
\uff08\u8bf7\u5728***\u63d0\u4ea4***\u524d\u5220\u9664\u8fd9\u6bb5\u63cf\u8ff0\uff09
\u9519\u522b\u5b57\u4fee\u6539\u3001\u65b0 demo\u3001\u8f83\u5c0f\u7684 bugfix \u90fd\u53ef\u4ee5\u76f4\u63a5\u63d0\u5230 `dev` \u5206\u652f\uff1b\u65b0\u9700\u6c42\u4ee5\u53ca\u4efb\u4f55\u4f60\u4e0d\u786e\u5b9a\u5f71\u54cd\u9762\u7684\u6539\u52a8\uff0c\u8bf7\u63d0\u4ea4\u5230\u5bf9\u5e94\u201c\u9886\u57df\u201d\u7684\u5206\u652f\uff08`ios`\u3001`android`\u3001`jsfm`\u3001`html5`\uff09\u3002
\u67e5\u770b\u5b8c\u6574\u7684[\u5206\u652f\u7b56\u7565 (\u82f1\u6587)](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management)\u3002
-->
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/LouisLWang/incubator-weex master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 56c0f951e624a94b7a2f5c14c1f3a29015918ff2
Author: JZTech-Wangll <lo...@louis-macbook-pro.local>
Date: 2017-03-06T09:50:56Z
fix WXWebView weak reference with delegate when WXWebView dealloc, fix hit reply too quickly cause view render crash
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #38: fix WXWebView weak reference with delegate when WX...
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on the issue:
https://github.com/apache/incubator-weex/pull/38
Got it - -
On 2017\u5e743\u67089\u65e5 +0800 PM8:09, sospartan zheng <no...@github.com>, wrote:
> I suggest don't merge directly next time, but notify contributor to re-send
> PR to correct branch.
> \u9690\u5c0f\u98ce <no...@github.com>\u4e8e2017\u5e743\u67089\u65e5 \u5468\u56db\u4e0b\u53486:58\u5199\u9053\uff1a
>
> > @LouisLWang <https://github.com/LouisLWang> I have merged your pull
> > requests to 0.11-dev, you can just close this issue
> >
> > \u2014
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <https://github.com/apache/incubator-weex/pull/38#issuecomment-285320982>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/AAHCAebcbTZlqK-BN-67Lc8g5zdQnxJnks5rj9tLgaJpZM4MT7o4>
> > .
> >
> --
> sospartan
> Phone:13588488290
> HangZhou
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #38: fix WXWebView weak reference with delegate ...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/38#discussion_r104574263
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -23,7 +23,7 @@ @implementation WXWebView
- (void)dealloc
{
if (self) {
- self.delegate = nil;
+// self.delegate = nil;
--- End diff --
just remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #38: fix WXWebView weak reference with delegate ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #38: fix WXWebView weak reference with delegate when WX...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/38
I suggest don't merge directly next time, but notify contributor to re-send
PR to correct branch.
\u9690\u5c0f\u98ce <no...@github.com>\u4e8e2017\u5e743\u67089\u65e5 \u5468\u56db\u4e0b\u53486:58\u5199\u9053\uff1a
> @LouisLWang <https://github.com/LouisLWang> I have merged your pull
> requests to 0.11-dev, you can just close this issue
>
> \u2014
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-weex/pull/38#issuecomment-285320982>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAHCAebcbTZlqK-BN-67Lc8g5zdQnxJnks5rj9tLgaJpZM4MT7o4>
> .
>
--
sospartan
Phone:13588488290
HangZhou
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #38: fix WXWebView weak reference with delegate when WX...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/38
@cxfeng1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #38: fix WXWebView weak reference with delegate when WX...
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on the issue:
https://github.com/apache/incubator-weex/pull/38
@LouisLWang I have merged your pull requests to 0.11-dev, you can just close this issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---