You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/08/27 16:19:19 UTC
[GitHub] [dubbo-go] YongHaoWu opened a new pull request #730: chore: Remove unnecessary return and judgement.
YongHaoWu opened a new pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #730: Mod: Remove unnecessary return and judgement.
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #730: Mod: Remove unnecessary return and judgement.
Posted by GitBox <gi...@apache.org>.
zouyx commented on pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#issuecomment-683230237
> @zouyx hi, about the `travis` error, it is strange that my commit base on `develop` branch will pass( it was based on `master` branch before). Is it the reason why it reported error?
Maybe.........
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] YongHaoWu commented on a change in pull request #730: Mod: Remove unnecessary return and judgement.
Posted by GitBox <gi...@apache.org>.
YongHaoWu commented on a change in pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#discussion_r479606213
##########
File path: registry/protocol/protocol.go
##########
@@ -21,23 +21,21 @@ import (
"context"
"strings"
"sync"
-)
Review comment:
@zouyx Hi, I still not do the changes yet. Will do later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #730: chore: Remove unnecessary return and judgement.
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#discussion_r478585105
##########
File path: common/rpc_service.go
##########
@@ -24,14 +24,9 @@ import (
"sync"
"unicode"
"unicode/utf8"
-)
-import (
- perrors "github.com/pkg/errors"
-)
-
-import (
"github.com/apache/dubbo-go/common/logger"
+ perrors "github.com/pkg/errors"
Review comment:
hey, guy, pls do not change our import code format. recover it pls.
##########
File path: config/base_config.go
##########
@@ -22,15 +22,10 @@ import (
"reflect"
"strconv"
"strings"
-)
-
-import (
- perrors "github.com/pkg/errors"
-)
-import (
"github.com/apache/dubbo-go/common/config"
"github.com/apache/dubbo-go/common/logger"
+ perrors "github.com/pkg/errors"
Review comment:
recover it pls.
##########
File path: config/reference_config.go
##########
@@ -23,20 +23,16 @@ import (
"net/url"
"strconv"
"time"
-)
-import (
"github.com/creasty/defaults"
- gxstrings "github.com/dubbogo/gost/strings"
-)
-import (
"github.com/apache/dubbo-go/cluster/directory"
"github.com/apache/dubbo-go/common"
"github.com/apache/dubbo-go/common/constant"
"github.com/apache/dubbo-go/common/extension"
"github.com/apache/dubbo-go/common/proxy"
"github.com/apache/dubbo-go/protocol"
+ gxstrings "github.com/dubbogo/gost/strings"
Review comment:
recove it.
##########
File path: registry/protocol/protocol.go
##########
@@ -21,23 +21,21 @@ import (
"context"
"strings"
"sync"
-)
-import (
- gxset "github.com/dubbogo/gost/container/set"
-)
-import (
"github.com/apache/dubbo-go/common"
"github.com/apache/dubbo-go/common/constant"
"github.com/apache/dubbo-go/common/extension"
"github.com/apache/dubbo-go/common/logger"
"github.com/apache/dubbo-go/common/proxy/proxy_factory"
"github.com/apache/dubbo-go/config"
"github.com/apache/dubbo-go/config_center"
+ gxset "github.com/dubbogo/gost/container/set"
Review comment:
recover it.
##########
File path: remoting/zookeeper/curator_discovery/service_discovery.go
##########
@@ -22,18 +22,14 @@ import (
"path"
"strings"
"sync"
-)
-import (
"github.com/dubbogo/go-zookeeper/zk"
- perrors "github.com/pkg/errors"
-)
-import (
"github.com/apache/dubbo-go/common/constant"
"github.com/apache/dubbo-go/common/logger"
"github.com/apache/dubbo-go/remoting"
"github.com/apache/dubbo-go/remoting/zookeeper"
+ perrors "github.com/pkg/errors"
Review comment:
recover it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #730: Mod: Remove unnecessary return and judgement.
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#discussion_r478846505
##########
File path: common/rpc_service.go
##########
@@ -24,14 +24,9 @@ import (
"sync"
"unicode"
"unicode/utf8"
-)
-import (
- perrors "github.com/pkg/errors"
-)
-
-import (
"github.com/apache/dubbo-go/common/logger"
+ perrors "github.com/pkg/errors"
Review comment:
> @AlexStocks Hi, this is `vim-go` 's behavior. I think it 'll change `import order` sorted by alphabet. Can you accept this?
no. we dubbo-go all code files follow the same import code style. we really appreciate ur contribution. However, u should follow our code rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #730: Mod: Remove unnecessary return and judgement.
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#discussion_r478846505
##########
File path: common/rpc_service.go
##########
@@ -24,14 +24,9 @@ import (
"sync"
"unicode"
"unicode/utf8"
-)
-import (
- perrors "github.com/pkg/errors"
-)
-
-import (
"github.com/apache/dubbo-go/common/logger"
+ perrors "github.com/pkg/errors"
Review comment:
> @AlexStocks Hi, this is `vim-go` 's behavior. I think it 'll change `import order` sorted by alphabet. Can you accept this?
no. we dubbo-go all code files follow the same import code style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] YongHaoWu commented on a change in pull request #730: chore: Remove unnecessary return and judgement.
Posted by GitBox <gi...@apache.org>.
YongHaoWu commented on a change in pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#discussion_r478798728
##########
File path: common/rpc_service.go
##########
@@ -24,14 +24,9 @@ import (
"sync"
"unicode"
"unicode/utf8"
-)
-import (
- perrors "github.com/pkg/errors"
-)
-
-import (
"github.com/apache/dubbo-go/common/logger"
+ perrors "github.com/pkg/errors"
Review comment:
@AlexStocks Hi, this is `vim-go` 's behavior. I think it 'll change `import order` sorted by alphabet. Can you accept this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] YongHaoWu commented on a change in pull request #730: Mod: Remove unnecessary return and judgement.
Posted by GitBox <gi...@apache.org>.
YongHaoWu commented on a change in pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#discussion_r478913074
##########
File path: common/rpc_service.go
##########
@@ -24,14 +24,9 @@ import (
"sync"
"unicode"
"unicode/utf8"
-)
-import (
- perrors "github.com/pkg/errors"
-)
-
-import (
"github.com/apache/dubbo-go/common/logger"
+ perrors "github.com/pkg/errors"
Review comment:
@AlexStocks Sure, I will keep it as the same. ps, Could u share the `import code style`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #730: Mod: Remove unnecessary return and judgement.
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#discussion_r479602165
##########
File path: config/base_config.go
##########
@@ -22,15 +22,10 @@ import (
"reflect"
"strconv"
"strings"
-)
-
-import (
- perrors "github.com/pkg/errors"
-)
-import (
"github.com/apache/dubbo-go/common/config"
"github.com/apache/dubbo-go/common/logger"
+ perrors "github.com/pkg/errors"
Review comment:
Still wrong style
##########
File path: filter/filter_impl/access_log_filter.go
##########
@@ -23,9 +23,7 @@ import (
"reflect"
"strings"
"time"
-)
Review comment:
recover it
##########
File path: config/reference_config.go
##########
@@ -23,20 +23,16 @@ import (
"net/url"
"strconv"
"time"
-)
-import (
"github.com/creasty/defaults"
- gxstrings "github.com/dubbogo/gost/strings"
-)
-import (
"github.com/apache/dubbo-go/cluster/directory"
"github.com/apache/dubbo-go/common"
"github.com/apache/dubbo-go/common/constant"
"github.com/apache/dubbo-go/common/extension"
"github.com/apache/dubbo-go/common/proxy"
"github.com/apache/dubbo-go/protocol"
+ gxstrings "github.com/dubbogo/gost/strings"
Review comment:
still wrong style
##########
File path: protocol/rest/rest_exporter.go
##########
@@ -19,9 +19,7 @@ package rest
import (
"sync"
-)
Review comment:
as above
##########
File path: remoting/zookeeper/curator_discovery/service_discovery.go
##########
@@ -22,18 +22,14 @@ import (
"path"
"strings"
"sync"
-)
-import (
Review comment:
recover all import style in this file
##########
File path: registry/protocol/protocol.go
##########
@@ -21,23 +21,21 @@ import (
"context"
"strings"
"sync"
-)
Review comment:
recover all import style in this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] YongHaoWu commented on a change in pull request #730: Mod: Remove unnecessary return and judgement.
Posted by GitBox <gi...@apache.org>.
YongHaoWu commented on a change in pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#discussion_r479607582
##########
File path: registry/protocol/protocol.go
##########
@@ -21,23 +21,21 @@ import (
"context"
"strings"
"sync"
-)
Review comment:
@zouyx hey, it's done now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #730: Mod: Remove unnecessary return and judgement.
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#discussion_r479389798
##########
File path: common/rpc_service.go
##########
@@ -24,14 +24,9 @@ import (
"sync"
"unicode"
"unicode/utf8"
-)
-import (
- perrors "github.com/pkg/errors"
-)
-
-import (
"github.com/apache/dubbo-go/common/logger"
+ perrors "github.com/pkg/errors"
Review comment:
refer to https://github.com/apache/dubbo-go/blob/develop/contributing.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] YongHaoWu commented on pull request #730: Mod: Remove unnecessary return and judgement.
Posted by GitBox <gi...@apache.org>.
YongHaoWu commented on pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#issuecomment-682389240
@zouyx hi, about the `travis` error, it is strange that my commit base on `develop` branch will pass( it was based on `master` branch before). Is it the reason why it reported error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org