You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/29 02:11:29 UTC
[GitHub] [shardingsphere-elasticjob-lite] Mark-WJQ opened a new pull request #864: updae some version
Mark-WJQ opened a new pull request #864:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/864
Fixes #852 .
Changes proposed in this pull request:
1. import spring-boot-dependencies in dependencyManagement with the scope of import,so we can use springboot in sub module,the version is 2.3.1.RELEASE.
2. unpdate spring version range [3.1.0.RELEASE,5.0.0.M1) to [3.1.0.RELEASE,5.0.0.M1)
3. update lombok version 1.16.4 to 1.18.12
4. update aspectj.version 1.8.0 to 1.9.1
5. update logback.version 1.1.2 to 1.2.3
6. I run the comman 'mvn clean install -U -T 4',it's ok,all tests are pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] Mark-WJQ commented on a change in pull request #864: update some version
Posted by GitBox <gi...@apache.org>.
Mark-WJQ commented on a change in pull request #864:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/864#discussion_r446768312
##########
File path: pom.xml
##########
@@ -43,17 +43,17 @@
<maven.version.range>[3.0.4,)</maven.version.range>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.build.locale>zh_CN</project.build.locale>
-
- <springframework.version>[3.1.0.RELEASE,5.0.0.M1)</springframework.version>
-
+
+ <springframework.version>[3.1.0.RELEASE,5.2.7.RELEASE]</springframework.version>
Review comment:
I get it, how do you think '<springframework.version>[3.1.0.RELEASE,)</springframework.version>' ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] terrymanu commented on a change in pull request #864: update some version
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #864:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/864#discussion_r446850939
##########
File path: pom.xml
##########
@@ -43,17 +43,17 @@
<maven.version.range>[3.0.4,)</maven.version.range>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.build.locale>zh_CN</project.build.locale>
-
- <springframework.version>[3.1.0.RELEASE,5.0.0.M1)</springframework.version>
-
+
+ <springframework.version>[3.1.0.RELEASE,5.2.7.RELEASE]</springframework.version>
Review comment:
Great
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #864: update some version
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #864:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/864
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob-lite] terrymanu commented on a change in pull request #864: updae some version
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #864:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/864#discussion_r446766321
##########
File path: pom.xml
##########
@@ -43,17 +43,17 @@
<maven.version.range>[3.0.4,)</maven.version.range>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.build.locale>zh_CN</project.build.locale>
-
- <springframework.version>[3.1.0.RELEASE,5.0.0.M1)</springframework.version>
-
+
+ <springframework.version>[3.1.0.RELEASE,5.2.7.RELEASE]</springframework.version>
Review comment:
If spring framework upgrade to new version, we still need to modify here,
can we keep the upper boundary open?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org