You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/20 20:58:25 UTC

[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #58: Rename akka package to org.apache.pekko

mdedetrich commented on code in PR #58:
URL: https://github.com/apache/incubator-pekko/pull/58#discussion_r1027352384


##########
.scalafix.conf:
##########
@@ -46,5 +46,5 @@ SortImports.blocks = [
   "scala.",
   "*",
   "com.sun."
-  "akka."
+  "org.apache.conf."

Review Comment:
   > should this be "org.apache.pekko."? 
   
   Thanks for pickup, done
   
   > Could you keep "akka." too - because pekko-http and other repos like that may keep their akka dependencies for a small period of time - until we have regular nightly jars of the core pekko modules.
   
   This has nothing to do with dependencies, its used by scalafix to sort imports and none of the imports in our code will ever have `akka` in it (thats actually what this PR changes).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org