You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "tferullo-bunsen (via GitHub)" <gi...@apache.org> on 2023/04/17 17:14:30 UTC
[GitHub] [beam] tferullo-bunsen opened a new pull request, #26300: [typescript] adds declaration to sdks/typescript/tsconfig.json
tferullo-bunsen opened a new pull request, #26300:
URL: https://github.com/apache/beam/pull/26300
fixes #26299, adds type declarations
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tferullo-bunsen closed pull request #26300: [typescript] adds declaration to sdks/typescript/tsconfig.json
Posted by "tferullo-bunsen (via GitHub)" <gi...@apache.org>.
tferullo-bunsen closed pull request #26300: [typescript] adds declaration to sdks/typescript/tsconfig.json
URL: https://github.com/apache/beam/pull/26300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tferullo-bunsen commented on pull request #26300: [typescript] adds declaration to sdks/typescript/tsconfig.json
Posted by "tferullo-bunsen (via GitHub)" <gi...@apache.org>.
tferullo-bunsen commented on PR #26300:
URL: https://github.com/apache/beam/pull/26300#issuecomment-1511811324
there then seems to be an issue with the generated code. I'm going to leave the issue open but close this PR. Happy to contribute further just seems like considerable changes may need to be made to make the package consumable via npm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tferullo-bunsen commented on pull request #26300: [typescript] adds declaration to sdks/typescript/tsconfig.json
Posted by "tferullo-bunsen (via GitHub)" <gi...@apache.org>.
tferullo-bunsen commented on PR #26300:
URL: https://github.com/apache/beam/pull/26300#issuecomment-1511789460
to get the quickstart example to work the imports still are a little off. They'd have to be
```ts
import * as beam from "apache-beam";
import * as runner from "apache-beam/dist/src/apache_beam/runners";
import { requireForSerialization } from "apache-beam/dist/src/apache_beam/serialization";
```
but I don't want to mess with the project structure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org